pg.ddx.io  pgsql-general@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Kirk Wolak <wolakk@gmail.com>
Cc: pgsql-general@lists.postgresql.org
Subject: Re: Getting PSQL in Windows to support TAB/Autocomplete via modified readline...
Date: Wed, 23 Nov 2022 21:57:30 -0500
Message-ID: <3778127.1669258650@sss.pgh.pa.us> (raw)
In-Reply-To: <20221124022205.2uv6lz74qfo7rebn@awork3.anarazel.de>
References: <CACLU5mThm-uCtERMVHMoGED2EPfyS54j83WB20s_BmzVQuMkpg@mail.gmail.com>
	<3168699.1669046286@sss.pgh.pa.us>
	<20221123230256.m23somxrmvdyoimk@awork3.anarazel.de>
	<3755435.1669245082@sss.pgh.pa.us>
	<20221124004144.iosgze2qnmcctgsh@awork3.anarazel.de>
	<3769352.1669253309@sss.pgh.pa.us>
	<20221124022205.2uv6lz74qfo7rebn@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> I think it'd be easier to deal with this if COMPLETE_WITH_* caused the the
> containing function to return. Then the completions wouldn't need to be in one
> huge if-else if. Leaving msvc aside, that also seems nice for efficiency.

Yeah, that could be an easy quick-fix.  We'd need to refactor so that
the cleanup housekeeping at the bottom of psql_completion() was in a
wrapper function, but perhaps that wouldn't be too messy.

			regards, tom lane





view thread (28+ messages)  latest in thread

Message-ID: <3778127.1669258650@sss.pgh.pa.us>
Permalink:  ../3778127.1669258650@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3778127.1669258650@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-general@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, wolakk@gmail.com, pgsql-general@lists.postgresql.org
  Subject: Re: Getting PSQL in Windows to support TAB/Autocomplete via modified readline...
  In-Reply-To: <3778127.1669258650@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox