pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Torsten Förtsch <tfoertsch123@gmail.com>
Cc: pgsql-hackers@postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: minor bug
Date: Thu, 19 Jan 2023 12:25:18 -0500
Message-ID: <4176211.1674149118@sss.pgh.pa.us> (raw)
In-Reply-To: <4ae9feb22332aca790968b550f0016a1f97c3739.camel@cybertec.at>
References: <CAKkG4_kUevPqbmyOfLajx7opAQk6Cvwkvx0HRcFjSPfRPTXanA@mail.gmail.com>
	<b41b61c8ba52efa23d1079cc53c689713f5b1e0c.camel@cybertec.at>
	<2964581.1673969570@sss.pgh.pa.us>
	<d0af6fef161cf9a161f2b9377193b9099e73d17e.camel@cybertec.at>
	<3787515.1674072218@sss.pgh.pa.us>
	<4ae9feb22332aca790968b550f0016a1f97c3739.camel@cybertec.at>

Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Wed, 2023-01-18 at 15:03 -0500, Tom Lane wrote:
>> Ah, but that only happens if recoveryTarget == RECOVERY_TARGET_TIME.
>> Digging in the git history, I see that this did use to work as
>> I remember: we always extracted the record time before printing it.
>> That was accidentally broken in refactoring in c945af80c.  I think
>> the correct fix is more like the attached.

> Yes, you are right.  Your patch looks fine to me.

Pushed then.  Thanks for the report!

			regards, tom lane





view thread (10+ messages)  latest in thread

Message-ID: <4176211.1674149118@sss.pgh.pa.us>
Permalink:  ../4176211.1674149118@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/4176211.1674149118@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, tfoertsch123@gmail.com, michael@paquier.xyz
  Subject: Re: minor bug
  In-Reply-To: <4176211.1674149118@sss.pgh.pa.us>
  References: <CAKkG4_kUevPqbmyOfLajx7opAQk6Cvwkvx0HRcFjSPfRPTXanA@mail.gmail.com> <b41b61c8ba52efa23d1079cc53c689713f5b1e0c.camel@cybertec.at> <2964581.1673969570@sss.pgh.pa.us> <d0af6fef161cf9a161f2b9377193b9099e73d17e.camel@cybertec.at> <3787515.1674072218@sss.pgh.pa.us> <4ae9feb22332aca790968b550f0016a1f97c3739.camel@cybertec.at> <4176211.1674149118@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox