pg.ddx.io  pgsql-general@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Ondřej Bouda <obouda@email.cz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Cc: pgsql-general@lists.postgresql.org
Subject: Re: backend crash on DELETE, reproducible locally
Date: Tue, 06 Nov 2018 17:11:40 -0500
Message-ID: <5323.1541542300@sss.pgh.pa.us> (raw)
In-Reply-To: <20181106215457.h36ccb5wywatcqhz@alap3.anarazel.de>
References: <20181106194553.dynhd2xuivo56ymd@alvherre.pgsql>
	<33d144b9-5208-8d32-7e95-94ed4d2931b8@email.cz>
	<450.1541535425@sss.pgh.pa.us>
	<134c09b5-3eb0-bafd-2aeb-f383e1e21b8a@email.cz>
	<2432.1541538215@sss.pgh.pa.us>
	<2877.1541538838@sss.pgh.pa.us>
	<fc1fde8f-2e1d-3f8d-a583-82ba383c7fd2@email.cz>
	<4375.1541540840@sss.pgh.pa.us>
	<20181106215457.h36ccb5wywatcqhz@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2018-11-06 16:47:20 -0500, Tom Lane wrote:
>> Looks like somebody forgot to list
>> RELOPT_KIND_GIST in RELOPT_KIND_INDEX, but is that the
>> fault of commit c203d6cf8 or was it busted before?

> Looks new:
> +   RELOPT_KIND_INDEX = RELOPT_KIND_BTREE|RELOPT_KIND_HASH|RELOPT_KIND_GIN|RELOPT_KIND_SPGIST,
> there aren't any other "for all indexes" type options, so the whole
> category didn't exist before.

> It also strikes me as a really bad idea, even if RELOPT_KIND_GIST
> wouldn't have been omitted: It breaks index am extensibility.

Hm, well, that enum already knows about all index types, doesn't it?

			regards, tom lane




view thread (38+ messages)  latest in thread

Message-ID: <5323.1541542300@sss.pgh.pa.us>
Permalink:  ../5323.1541542300@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/5323.1541542300@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-general@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, obouda@email.cz, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, pgsql-general@lists.postgresql.org
  Subject: Re: backend crash on DELETE, reproducible locally
  In-Reply-To: <5323.1541542300@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox