From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Sebastien Flaesch <sebastien.flaesch@4js.com>
Cc: pgsql-general@lists.postgresql.org <pgsql-general@lists.postgresql.org>
Subject: Re: lippq client library and openssl initialization: PQinitOpenSSL()
Date: Mon, 12 Sep 2022 13:21:57 +0200
Message-ID: <6b1946ab-b6ff-8f0c-22d9-2456b04dd1b3@enterprisedb.com> (raw)
In-Reply-To: <C3C3CD40-9F39-44DA-AFAA-AAD52002C3FA@yesql.se>
References: <DBAP191MB12895BFFEC4B5FE0460D0F2FB0459@DBAP191MB1289.EURP191.PROD.OUTLOOK.COM>
<816006.1662908880@sss.pgh.pa.us>
<9A09E47E-68EB-45DF-A934-FB76F2086D20@yesql.se>
<1206133.1662932104@sss.pgh.pa.us>
<C3C3CD40-9F39-44DA-AFAA-AAD52002C3FA@yesql.se>
On 11.09.22 23:43, Daniel Gustafsson wrote:
>> On 11 Sep 2022, at 23:35, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>
>> Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 11 Sep 2022, at 17:08, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>> Don't believe so. The HAVE_CRYPTO_LOCK stuff is all obsolete and
>>>> not compiled if you built against 1.1.0. The only thing left that
>>>> will happen if you don't call PQinitOpenSSL is an extra call to
>>>> OPENSSL_init_ssl, which should be harmless as far as I can see
>>>> from the OpenSSL docs.
>>
>>> To the best of my knowledge, thats entirely correct.
>>
>> Should we document these functions as obsolete when using
>> OpenSSL >= 1.1.0 ?
>
> Given that 1.1.0+ is very common, it's probably not a bad idea to document them
> as obsolete but harmless. Unless you beat me to it I can propose a patch.
AFAICT, RHEL 7 ships with an older version. I think that's still pretty
widespread.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-general@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, daniel@yesql.se, tgl@sss.pgh.pa.us, sebastien.flaesch@4js.com
Subject: Re: lippq client library and openssl initialization: PQinitOpenSSL()
In-Reply-To: <6b1946ab-b6ff-8f0c-22d9-2456b04dd1b3@enterprisedb.com>
References: <DBAP191MB12895BFFEC4B5FE0460D0F2FB0459@DBAP191MB1289.EURP191.PROD.OUTLOOK.COM> <816006.1662908880@sss.pgh.pa.us> <9A09E47E-68EB-45DF-A934-FB76F2086D20@yesql.se> <1206133.1662932104@sss.pgh.pa.us> <C3C3CD40-9F39-44DA-AFAA-AAD52002C3FA@yesql.se> <6b1946ab-b6ff-8f0c-22d9-2456b04dd1b3@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox