From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andrus <kobruleht2@hot.ee>
Cc: pgsql-general@postgresql.org
Subject: Re: Error messages on duplicate schema names
Date: Wed, 20 Jan 2021 11:56:03 +0900
Message-ID: <YAebw/WH0t6YCd8S@paquier.xyz> (raw)
In-Reply-To: <20210119203751.GA5473@alvherre.pgsql>
References: <YAEZ6D+R5tSGk08i@paquier.xyz>
<20210119203751.GA5473@alvherre.pgsql>
On Tue, Jan 19, 2021 at 05:37:51PM -0300, Alvaro Herrera wrote:
> I guess you could make the case that the CCI call should be in the
> callers where we actually loop (SetDefaultACLsInSchemas,
> RemoveRoleFromObjectACL), but it's hard to get excited about the added
> clutter.
Yeah, that matches my thoughts. And I did not see any harm in putting
the CCI in SetDefaultACL() even for the case of pg_default_acl with
DROP OWNED BY. So applied and backpatched. Thanks, Alvaro and
Andrus.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-general@postgresql.org
Cc: michael@paquier.xyz, alvherre@alvh.no-ip.org, kobruleht2@hot.ee
Subject: Re: Error messages on duplicate schema names
In-Reply-To: <YAebw/WH0t6YCd8S@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox