public inbox for [email protected]  

help / color / mirror / Atom feed
From: Mircea Cadariu <[email protected]>
To: Laurenz Albe <[email protected]>
To: Zechman, Derek S <[email protected]>
To: Adrian Klaver <[email protected]>
To: [email protected] <[email protected]>
Subject: Re: analyze-in-stages post upgrade questions
Date: Thu, 10 Jul 2025 17:20:02 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CO1PR04MB8281387B9AD9DE30976966BBC045A@CO1PR04MB8281.namprd04.prod.outlook.com>
	<[email protected]>
	<[email protected]>
	<PH0PR04MB82943D67CD179002714AA503C044A@PH0PR04MB8294.namprd04.prod.outlook.com>
	<[email protected]>
	<PH0PR04MB8294E796D6297D4E3BE4EFB6C049A@PH0PR04MB8294.namprd04.prod.outlook.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi Laurenz,


Got it. I have only one suggestion for the patch. Consider adding a 
corresponding test in src/bin/scripts/t/100_vacuumdb.pl.

Proposal (I used this to check the patch):

$node->safe_psql('postgres',
     "CREATE TABLE parent_table (a INT) PARTITION BY LIST (a);\n"
       . "CREATE TABLE child_table PARTITION OF parent_table FOR VALUES 
IN (1);\n"
       . "INSERT INTO parent_table VALUES (1);\n");
$node->issues_sql_like(
     [
         'vacuumdb', '--analyze-only', 'postgres'
     ],
     qr/statement:\s+ANALYZE\s+public\.parent_table/s,
     '--analyze_only updates statistics for partitioned tables');


Kind regards,

Mircea Cadariu







view thread (19+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: analyze-in-stages post upgrade questions
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox