From: Cott Lang <cott@internetstaff.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers-pitr@postgresql.org
Subject: Re: Review of last summer's PITR patch
Date: Thu, 12 Feb 2004 18:25:35 -0700
Message-ID: <1076635535.4314.1.camel@blackbox> (raw)
In-Reply-To: <25866.1076634863@sss.pgh.pa.us>
References: <25856.1076553698@sss.pgh.pa.us>
<1076633300.4312.214.camel@blackbox>
<25866.1076634863@sss.pgh.pa.us>
On Thu, 2004-02-12 at 18:14, Tom Lane wrote:
> Cott Lang <cott@internetstaff.com> writes:
> > * The ability to force a WAL log switch to ensure all changes during the
> > backup are flushed to archived logs and copied.
>
> Why does that require a log switch? You can copy the active log file in
> any case. (There was actually code to do that in J.R.'s patch, which I
> disregarded because I see no point in it ...)
Maybe it doesn't, I'm certainly no expert in PG internals. :)
It just seems like a Good Thing (TM) to ensure that any possible changes
to the data files during the backup are in the logs that are copied to
the archive destination and backed up as part of the hot backup.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers-pitr@postgresql.org
Cc: cott@internetstaff.com, tgl@sss.pgh.pa.us
Subject: Re: Review of last summer's PITR patch
In-Reply-To: <1076635535.4314.1.camel@blackbox>
References: <25856.1076553698@sss.pgh.pa.us> <1076633300.4312.214.camel@blackbox> <25866.1076634863@sss.pgh.pa.us> <1076635535.4314.1.camel@blackbox>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox