pg.ddx.io  pgsql-hackers-win32@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Oliver Jowett <oliver@opencloud.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Merlin Moncure <merlin.moncure@rcsonline.com>
Cc: pgsql-patches@postgresql.org
Cc: pgsql-hackers-win32@postgresql.org
Subject: Re: [PATCHES] Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL
Date: Fri, 09 Sep 2005 11:49:54 +1200
Message-ID: <4320CE22.4070408@opencloud.com> (raw)
In-Reply-To: <26710.1126222815@sss.pgh.pa.us>
References: <6EE64EF3AB31D5448D0007DD34EEB3417DD2C6@Herge.rcsinc.local>
	<4320C4BE.7010306@opencloud.com>
	<26590.1126221622@sss.pgh.pa.us>
	<4320CA2E.1000104@opencloud.com>
	<26710.1126222815@sss.pgh.pa.us>

Tom Lane wrote:
> Oliver Jowett <oliver@opencloud.com> writes:
> 
>>The assumption I'm making is that if the TCP_* values are present at
>>compile time, then you can make a setsockopt() call and get a sane error
>>code back if there's no support -- rather than a segfault, or having the
>>OS spontaneously do weird things to the connection, or anything like
>>that. Is that a reasonable thing to assume?
> 
> 
> Well, on a sane OS it's reasonable.  I dunno about Windows ;-)
> 
> One question to ask is whether we should treat the setsockopt failure
> as fatal or not.  It seems to me that aborting the connection could
> reasonably be called an overreaction to a bad parameter setting;
> couldn't we just set the GUC variable to zero and keep going?

There's no real reason why not; currently the code looks like this:

>   /* Set default keepalive parameters. This should also catch
>    * misconfigurations (non-zero values when socket options aren't
>    * supported)
>    */
>   if (pq_setkeepalivesidle(tcp_keepalives_idle, port) != STATUS_OK)
>     return STATUS_ERROR;
> 
>   if (pq_setkeepalivesinterval(tcp_keepalives_interval, port) != STATUS_OK)
>     return STATUS_ERROR;
> 
>   if (pq_setkeepalivescount(tcp_keepalives_count, port) != STATUS_OK)
>     return STATUS_ERROR;

We could just log (already done inside pq_*, IIRC) and continue, instead
of erroring out. It's just the way it is because I personally prefer
misconfigurations to break loudly, so you have to fix them ;-)

-O



view thread (12+ messages)  latest in thread

Message-ID: <4320CE22.4070408@opencloud.com>
Permalink:  ../4320CE22.4070408@opencloud.com/
Also on:    postgresql.org/message-id/4320CE22.4070408@opencloud.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers-win32@postgresql.org
  Cc: oliver@opencloud.com, tgl@sss.pgh.pa.us, merlin.moncure@rcsonline.com, pgsql-patches@postgresql.org
  Subject: Re: [PATCHES] Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL
  In-Reply-To: <4320CE22.4070408@opencloud.com>
  References: <6EE64EF3AB31D5448D0007DD34EEB3417DD2C6@Herge.rcsinc.local> <4320C4BE.7010306@opencloud.com> <26590.1126221622@sss.pgh.pa.us> <4320CA2E.1000104@opencloud.com> <26710.1126222815@sss.pgh.pa.us> <4320CE22.4070408@opencloud.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox