From: Nikita Glukhov <n.gluhov@postgrespro.ru>
To: David Steele <david@pgmasters.net>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: jsonpath syntax extensions
Date: Wed, 4 Mar 2020 23:18:52 +0300
Message-ID: <00706fa4-7ee3-bbb0-a497-e332035164f5@postgrespro.ru> (raw)
In-Reply-To: <aa27cf2e-dc75-1192-2801-019c62e83b1a@pgmasters.net>
References: <e0fe4f7b-da0b-471c-b3da-d8adaf314357@postgrespro.ru>
<aa27cf2e-dc75-1192-2801-019c62e83b1a@pgmasters.net>
On 04.03.2020 19:13, David Steele wrote:
> Hi Nikita,
>
> On 2/27/20 10:57 AM, Nikita Glukhov wrote:
>>
>> Attached patches implement several useful jsonpath syntax extensions.
>> I already published them two years ago in the original SQL/JSON thread,
>> but then after creation of separate threads for SQL/JSON functions and
>> JSON_TABLE I forgot about them.
>
> Are these improvements targeted at PG13 or PG14? This seems to be a
> pretty big change for the last CF of PG13. I know these have been
> submitted before but that was a few years ago so I think they count as
> new.
I believe that some of these improvements can get into PG13. There is no need
to review all of them, we can choose only the simplest ones.
Most of code changes in #3-#5 consist of straightforward boilerplate jsonpath
I/O code, and only changes in jsonpath_exec.c are interesting.
Only the patch #1 is mandatory, patches #3-#6 depend on it.
The patch #2 is not necessary, if jbvArray and jbvObject values would be
wrapped into jbvBinary by JsonbValueToJsonb() call in #4 and #5.
Patch #4 is the simplest one (only 20 new lines of code in jsonpath_exec.c).
Patch #6 is the most complex one, and it affects only jsonpath execution.
--
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: n.gluhov@postgrespro.ru, david@pgmasters.net
Subject: Re: jsonpath syntax extensions
In-Reply-To: <00706fa4-7ee3-bbb0-a497-e332035164f5@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox