pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: myungkyu.lim <myungkyu.lim@samsung.com>
To: 'Masahiko Sawada' <sawada.mshk@gmail.com>
Cc: 'PostgreSQL-development' <pgsql-hackers@postgresql.org>
Cc: woosung.sohn@samsung.com
Cc: don.hong@samsung.com
Subject: RE: [Todo item] Add entry creation timestamp column to pg_stat_replication
Date: Thu, 15 Nov 2018 17:02:31 +0900
Message-ID: <007701d47cb9$8f414380$adc3ca80$@samsung.com> (raw)
References: <CGME20181115080226epcas4p1f81c51691d9f12f7fa94c198e84edb3a@epcas4p1.samsung.com>

Hi.

>> I changed field name from 'reply_time' to 'last_msg_send_time'.
>> Because 'last_msg_send_time' is used in pg_stat_wal_receiver/pg_stat_subsctiption view.
>> I think that field has the same meaning.
>
>I got confused by the field name. If we have 'last_msg_send_time'
>field in pg_stat_replciation which has information of wal senders
>users would think it as a time when the wal sender sent a message last
>time. However values of the fields actually shows a time when the wal
>receiver sent a reply message last time. So perhaps
>'last_reply_send_time' would be more clear.

Good point. 'last_reply_send_time' is better.
How about just 'reply_time'?

Best regards,
Myungkyu, Lim





view thread (22+ messages)  latest in thread

Message-ID: <007701d47cb9$8f414380$adc3ca80$@samsung.com>
Permalink:  ../007701d47cb9$8f414380$adc3ca80$@samsung.com/
Also on:    postgresql.org/message-id/007701d47cb9$8f414380$adc3ca80$@samsung.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: myungkyu.lim@samsung.com, sawada.mshk@gmail.com, woosung.sohn@samsung.com, don.hong@samsung.com
  Subject: RE: [Todo item] Add entry creation timestamp column to pg_stat_replication
  In-Reply-To: <007701d47cb9$8f414380$adc3ca80$@samsung.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox