pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: myungkyu.lim <myungkyu.lim@samsung.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: woosung.sohn@samsung.com
Cc: don.hong@samsung.com
Subject: Re: [Todo item] Add entry creation timestamp column to pg_stat_replication
Date: Sun, 9 Dec 2018 16:44:57 +0900
Message-ID: <20181209074457.GF1833@paquier.xyz> (raw)
In-Reply-To: <063901d48df8$83d22460$8b766d20$@samsung.com>
References: <010201d4854b$ae87e510$0b97af30$@samsung.com>
	<20181129070020.GD2356@paquier.xyz>
	<00d401d487bf$98727c10$c9577430$@samsung.com>
	<20181130085415.GI2267@paquier.xyz>
	<20181204035625.GQ3423@paquier.xyz>
	<20181204060657.GA6859@paquier.xyz>
	<03f901d48ba2$6398d430$2aca7c90$@samsung.com>
	<CGME20181207064127epcas2p3f74fed96e5142f2a25487749628a605d@epcas2p3.samsung.com>
	<20181207064034.GR2407@paquier.xyz>
	<063901d48df8$83d22460$8b766d20$@samsung.com>

On Fri, Dec 07, 2018 at 03:45:59PM +0900, myungkyu.lim wrote:
> Thank you for your attention!

And committed.  There was one thing that the patch was doing wrong:
there is no point to convert the timestamp to a string if no log message
is generated, so I have added a check on log_min_messages to avoid the
extra processing for normal workloads, and pushed.

Thanks for the patch, TODO_item--.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20181209074457.GF1833@paquier.xyz/2-signature.asc)
  download

view thread (22+ messages)

Message-ID: <20181209074457.GF1833@paquier.xyz>
Permalink:  ../20181209074457.GF1833@paquier.xyz/
Also on:    postgresql.org/message-id/20181209074457.GF1833@paquier.xyz

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, myungkyu.lim@samsung.com, sawada.mshk@gmail.com, woosung.sohn@samsung.com, don.hong@samsung.com
  Subject: Re: [Todo item] Add entry creation timestamp column to pg_stat_replication
  In-Reply-To: <20181209074457.GF1833@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox