public inbox for [email protected]  

help / color / mirror / Atom feed

From: [email protected]
To: Ivan Kush <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: pg_stat_statements: improve loading and saving routines for the dump file
Date: Wed, 22 Jan 2025 16:54:40 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

> What does this patch give on aglobal scale? Does it save much memory or 
> increase performance? How many times?

This patch makes the code semantically more correct and we don't lose 
anything. It is obviously not about performance or memory optimisation.

> This will only reduce the size of the
> $PGDATA/pg_stat/pg_stat_statements.txt file. Even with
> 100k entries, the most I have seen pg_stat_statements.max
> set to, that will be less than 1 MB of disk saving. The default
> config of 5k entries will be much less.

Perfectly agree. I would just add that statistics are dropped into the 
pg_stat_statements.txt file at server stop which is not a very frequent 
event.

Respectfully,

Mikhail Litsarev,
Postgres Professional: https://postgrespro.com

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg_stat_statements: improve loading and saving routines for the dump file
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox