pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add support for automatically updating Unicode derived files
Date: Mon, 20 Jan 2020 09:59:34 +0100
Message-ID: <02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com> (raw)
In-Reply-To: <26652.1579048650@sss.pgh.pa.us>
References: <c8d05f42-443e-6c23-819b-05b31759a37c@2ndquadrant.com>
	<CACPNZCv2jmjpqkatr-NBJ8wpP6trY8MPBbW8nhqi--hL-0+dgQ@mail.gmail.com>
	<ff2f8e99-ac2b-1940-81c5-8b2fd1e674e7@2ndquadrant.com>
	<CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com>
	<acc8396a-4e06-e5d4-6d42-f710eef11ede@2ndquadrant.com>
	<26652.1579048650@sss.pgh.pa.us>

On 2020-01-15 01:37, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> Committed, thanks.
> 
> This patch is making src/tools/pginclude/headerscheck unhappy:
> 
> ./src/include/common/unicode_combining_table.h:3: error: array type has incomplete element type
> 
> I guess that header needs another #include, or else you need to
> move some declarations around.

Hmm, this file is only meant to be included inside one particular 
function.  Making it standalone includable would seem to be unnecessary. 
  What should we do?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (10+ messages)  latest in thread

Message-ID: <02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com>
Permalink:  ../02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com/
Also on:    postgresql.org/message-id/02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, john.naylor@2ndquadrant.com
  Subject: Re: Add support for automatically updating Unicode derived files
  In-Reply-To: <02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox