From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: John Naylor <john.naylor@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add support for automatically updating Unicode derived files
Date: Thu, 9 Jan 2020 10:16:19 +0100
Message-ID: <acc8396a-4e06-e5d4-6d42-f710eef11ede@2ndquadrant.com> (raw)
In-Reply-To: <CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com>
References: <c8d05f42-443e-6c23-819b-05b31759a37c@2ndquadrant.com>
<CACPNZCv2jmjpqkatr-NBJ8wpP6trY8MPBbW8nhqi--hL-0+dgQ@mail.gmail.com>
<ff2f8e99-ac2b-1940-81c5-8b2fd1e674e7@2ndquadrant.com>
<CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com>
On 2020-01-03 15:13, John Naylor wrote:
> On Thu, Dec 26, 2019 at 12:39 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> On 2019-12-19 23:48, John Naylor wrote:
>>> I would print out the full boilerplate like for other generated headers.
>>
>> Hmm, you are probably comparing with
>> src/common/unicode/generate-unicode_norm_table.pl, but other file
>> generating scripts around the tree print out a small header in the style
>> that I have. I'd rather adjust the output of
>> generate-unicode_norm_table.pl to match those. (It's also not quite
>> correct to make copyright claims about automatically generated output.)
>
> Hmm, the scripts I'm most familiar with have full headers. Your point
> about copyright makes sense, and using smaller file headers would aid
> readability of the scripts, but I also see how others may feel
> differently.
>
> v2 looks good to me, marked ready for committer.
Committed, thanks.
I have added a little tweak so that it works also without --with-python,
to avoid gratuitous annoyances.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, john.naylor@2ndquadrant.com
Subject: Re: Add support for automatically updating Unicode derived files
In-Reply-To: <acc8396a-4e06-e5d4-6d42-f710eef11ede@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox