pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)
Date: Tue, 18 Dec 2018 11:52:50 +0500
Message-ID: <0388ee45-abfa-d419-f502-f9527efdb8a4@postgrespro.ru> (raw)
In-Reply-To: <CAH2-WzmOp3-gqp2S4UHL6nsSPfZMguy5ZU6EsTTevjha7LcUuQ@mail.gmail.com>
References: <CAH2-Wzkypv1R+teZrr71U23J578NnTBt2X8+Y=Odr4pOdW1rXg@mail.gmail.com>
	<0a89eb40-ea89-9037-aad0-3b65c67cdcbd@postgrespro.ru>
	<CAH2-Wz=WRpJeej2xpd+FbzJXYAZZPiTgebTGv1P2NMcvgzvZGw@mail.gmail.com>
	<CAH2-WzmQ7XeKspNyA+K4iRMaVcqquq8G1qtvfK_grdKV-1Oa9w@mail.gmail.com>
	<65ced322-84d2-777a-2fac-5f482c175431@postgrespro.ru>
	<CAH2-WznYm9bTi1N1+wTAK=cXTuH23oxFtPqpT_7kYGqS5Xdutw@mail.gmail.com>
	<3294d285-d3b3-e159-b3f7-6c2d1b059956@postgrespro.ru>
	<CAH2-WzmOp3-gqp2S4UHL6nsSPfZMguy5ZU6EsTTevjha7LcUuQ@mail.gmail.com>



On 08.12.2018 6:58, Peter Geoghegan wrote:
>   I have no idea what you mean here. I'm proposing a patch that stops
> it being a game of chance, while preserving the existing
> slightly-random behavior to the greatest extent possible. I think that
> my patch would have stopped that problem altogether. Are you
> suggesting that it wouldn't have?

I did many tests of your solution inside the 'quick vacuum' strategy [1] 
and the background worker called 'heap cleaner' [2]. I must admit that 
when I  use your patch, there is no problem with dependencies.
This patch needs opinion of an another reviewer.

[1] 
https://www.postgresql.org/message-id/425db134-8bba-005c-b59d-56e50de3b41e%40postgrespro.ru
[2] 
https://www.postgresql.org/message-id/f49bb262-d246-829d-f835-3950ddac503c%40postgrespro.ru

-- 
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company




view thread (84+ messages)  latest in thread

Message-ID: <0388ee45-abfa-d419-f502-f9527efdb8a4@postgrespro.ru>
Permalink:  ../0388ee45-abfa-d419-f502-f9527efdb8a4@postgrespro.ru/
Also on:    postgresql.org/message-id/0388ee45-abfa-d419-f502-f9527efdb8a4@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.lepikhov@postgrespro.ru, pg@bowt.ie, peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com
  Subject: Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)
  In-Reply-To: <0388ee45-abfa-d419-f502-f9527efdb8a4@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox