From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: client-side fsync() error handling
Date: Thu, 13 Feb 2020 10:02:31 +0100
Message-ID: <0412a2fb-cbde-08c6-9ff2-cfab5c27a3b8@2ndquadrant.com> (raw)
In-Reply-To: <20200212052819.GD1464@paquier.xyz>
References: <d239d1bd-aef0-ca7c-dc0a-da14bdcf0392@2ndquadrant.com>
<20200212052819.GD1464@paquier.xyz>
On 2020-02-12 06:28, Michael Paquier wrote:
> Now, don't we need to care about durable_rename() and make the
> panic-like failure an optional choice? From what I can see, this
> routine is used now in the backend for pg_basebackup to rename
> temporary history files or partial WAL segments.
durable_rename() calls fsync_fname(), so it would be covered by this
change. The other file access calls in there can be handled by normal
error handling, I think. Is there any specific scenario you have in mind?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz
Subject: Re: client-side fsync() error handling
In-Reply-To: <0412a2fb-cbde-08c6-9ff2-cfab5c27a3b8@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox