From: Yuhang Qiu <iamqyh@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add ALTER SYSTEM RELOAD
Date: Tue, 29 Sep 2026 15:46:51 +0800
Message-ID: <044D2C7B-06C2-4AED-B4FB-64C187B70B0B@gmail.com> (raw)
In-Reply-To: <1811098.1790278160@sss.pgh.pa.us>
References: <5A1F1E3B-D22F-487B-9480-D3DDB5F0C2A1@gmail.com>
<B254502B-2BF5-4A17-BA04-1E4AA6D878B3@gmail.com>
<1811098.1790278160@sss.pgh.pa.us>
Hi all,
Sorry for the late reply.
The v1 patch was mainly intended to discuss whether `RELOAD` belongs
under `ALTER SYSTEM`, so I did not cover the privilege design in detail.
I had in mind a separate ACL for `ALTER SYSTEM` operations, allowing
privileges to be granted per operation. If we add more operations,
predefined roles may be too broad to allow fine-grained control.
> I'm pretty down on this proposal even without the privilege question.
> "There's more than one way to do it" isn't a great thing for
> security-relevant operations, and this surely is one.
>
> Also, I don't like the loss of an explainable scope for what
> ALTER SYSTEM does.
I agree with Tom's concerns about adding a second interface and blurring
the scope of the command. I also agree with Andreas about the maintenance
cost. `pg_reload_conf()` already provides the reload operation, and the
`ALTER SYSTEM` documentation explains how to request a reload.
> This lack of intellectual consistency would get ten times worse
> if we followed through on the idea of overloading ALTER SYSTEM
> with unrelated actions like log rotation and promotion.
Agreed. Log rotation and promotion were simply the first operations that
came to mind as possible fits for a broader command family. Adding just
those two would not give ALTER SYSTEM a coherent scope. Oracle has a much
broader ALTER SYSTEM command family, though. If PostgreSQL developed a
similarly broad family of instance-level operations, could that give the
command a clearer scope? But still, it would increase the overlap with
existing functions that concerns Tom, as well as the maintenance cost
Andreas noted.
Thanks everyone for the reviews.
Best regards,
Yuhang Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: iamqyh@gmail.com, tgl@sss.pgh.pa.us, li.evan.chao@gmail.com
Subject: Re: [PATCH] Add ALTER SYSTEM RELOAD
In-Reply-To: <044D2C7B-06C2-4AED-B4FB-64C187B70B0B@gmail.com>
References: <5A1F1E3B-D22F-487B-9480-D3DDB5F0C2A1@gmail.com> <B254502B-2BF5-4A17-BA04-1E4AA6D878B3@gmail.com> <1811098.1790278160@sss.pgh.pa.us> <044D2C7B-06C2-4AED-B4FB-64C187B70B0B@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox