public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 8/8] default to --with-lz4
3+ messages / 3 participants
[nested] [flat]
* [PATCH 8/8] default to --with-lz4
@ 2021-03-10 09:14 Dilip Kumar <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Dilip Kumar @ 2021-03-10 09:14 UTC (permalink / raw)
this is meant to excercize the new feature in the CIs, and not meant to be merged
---
configure | 6 ++++--
configure.ac | 4 ++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 440d1e8ce5..b411ed1cb4 100755
--- a/configure
+++ b/configure
@@ -1575,7 +1575,7 @@ Optional Packages:
--with-system-tzdata=DIR
use system time zone data in DIR
--without-zlib do not use Zlib
- --with-lz4 build with LZ4 support
+ --without-lz4 build without LZ4 support
--with-gnu-ld assume the C compiler uses GNU ld [default=no]
--with-ssl=LIB use LIB for SSL/TLS support (openssl)
--with-openssl obsolete spelling of --with-ssl=openssl
@@ -8598,7 +8598,9 @@ $as_echo "#define USE_LZ4 1" >>confdefs.h
esac
else
- with_lz4=no
+ with_lz4=yes
+
+$as_echo "#define USE_LZ4 1" >>confdefs.h
fi
diff --git a/configure.ac b/configure.ac
index 780791ae8a..392784d55c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -990,8 +990,8 @@ AC_SUBST(with_zlib)
# LZ4
#
AC_MSG_CHECKING([whether to build with LZ4 support])
-PGAC_ARG_BOOL(with, lz4, no, [build with LZ4 support],
- [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build with LZ4 support. (--with-lz4)])])
+PGAC_ARG_BOOL(with, lz4, yes, [build without LZ4 support],
+ [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build without LZ4 support. (--without-lz4)])])
AC_MSG_RESULT([$with_lz4])
AC_SUBST(with_lz4)
--
2.17.0
--C94crkcyjafcjHxo--
^ permalink raw reply [nested|flat] 3+ messages in thread
* Avoid unused value (src/fe_utils/print.c)
@ 2023-06-03 10:14 Ranier Vilela <[email protected]>
2023-06-03 12:00 ` Re: Avoid unused value (src/fe_utils/print.c) Alexander Lakhin <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Ranier Vilela @ 2023-06-03 10:14 UTC (permalink / raw)
To: pgsql-hackers
Hi,
This is for Postgres 17 (head).
Per Coverity.
At function print_unaligned_text, variable "need_recordsep", is
unnecessarily set to true and false.
Attached a trivial fix patch.
regards,
Ranier Vilela
Attachments:
[application/octet-stream] avoid-unused-value-print.patch (461B, ../../CAEudQAqwC5=cwgyEhq6HZS6aF_2QB_DMTm0j2qfmQnPwgPVKdw@mail.gmail.com/3-avoid-unused-value-print.patch)
download | inline diff:
diff --git a/src/fe_utils/print.c b/src/fe_utils/print.c
index 7af1ccb6b5..89f970cb94 100644
--- a/src/fe_utils/print.c
+++ b/src/fe_utils/print.c
@@ -484,12 +484,8 @@ print_unaligned_text(const printTableContent *cont, FILE *fout)
for (f = footers; f; f = f->next)
{
if (need_recordsep)
- {
print_separator(cont->opt->recordSep, fout);
- need_recordsep = false;
- }
fputs(f->data, fout);
- need_recordsep = true;
}
}
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Avoid unused value (src/fe_utils/print.c)
2023-06-03 10:14 Avoid unused value (src/fe_utils/print.c) Ranier Vilela <[email protected]>
@ 2023-06-03 12:00 ` Alexander Lakhin <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Lakhin @ 2023-06-03 12:00 UTC (permalink / raw)
To: Ranier Vilela <[email protected]>; pgsql-hackers
Hello Ranier,
03.06.2023 13:14, Ranier Vilela wrote:
> Hi,
>
> This is for Postgres 17 (head).
>
> Per Coverity.
> At function print_unaligned_text, variable "need_recordsep", is
> unnecessarily set to true and false.
Clang' scan-build detects 58 errors "Dead assignment", including that one.
Maybe it would be more sensible to eliminate all errors of this class?
Best regards,
Alexander
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-06-03 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 09:14 [PATCH 8/8] default to --with-lz4 Dilip Kumar <[email protected]>
2023-06-03 10:14 Avoid unused value (src/fe_utils/print.c) Ranier Vilela <[email protected]>
2023-06-03 12:00 ` Re: Avoid unused value (src/fe_utils/print.c) Alexander Lakhin <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox