Re: trying again to get incremental backup

pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed

From: Alexander Lakhin <exclusion@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
To: Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: trying again to get incremental backup
Date: Thu, 21 Dec 2023 07:00:01 +0300
Message-ID: <061cccf7-0cac-804f-4c2a-9d6da8e3848b@gmail.com> (raw)
In-Reply-To: <CA+Tgmoar8+V1ycDPgT_-d+1pG_9uRn=qSPty2Y2PgNQBTqRsfQ@mail.gmail.com>
References: <CA+TgmoYiPn7GE_GFvGf+150XOt-Pkdm8h4rzy42jYCRrceUWhg@mail.gmail.com>
	<CA+Tgmob7CFCv99_bCRB=pWYat6r2rhgSqiEWQPJO67ywcb0Hpw@mail.gmail.com>
	<CA+TgmoZpBW2DHeeC--y0H3y1RGsUHb14vinZU4yqBAHtWgv-vg@mail.gmail.com>
	<CA+TgmoaiOhjd0pL630MSpZ_fyjFsARFC8RDBWxWL2FXPv65bJA@mail.gmail.com>
	<CAKZiRmxGN4Eu90xOt8cJwgjV67jNSFsA6Lc_1bgCT5KR-5ywJA@mail.gmail.com>
	<CA+Tgmob4VFT6CuVaxwO0JjLrmCoHF+NNm_f1LsCeSi5i82MeSA@mail.gmail.com>
	<CAKZiRmy73EKi3i5mdtcjn6r6WWQfKuri3HSQ+Pmdu_7g5Ef5kA@mail.gmail.com>
	<CA+TgmoYUhrgcNin=qrY+J+S-f6kctf9DaUKoaD-e3cww_ox9vg@mail.gmail.com>
	<CAKZiRmygUFo5Fa4y9cUwuhZNEJpP6Ng8AwbQDkYGuRAmK23zvg@mail.gmail.com>
	<CA+TgmobPUXTfGC-2BTGAu5tOQQV_4x0HdOw_6o__rC0+X+1Yzw@mail.gmail.com>
	<CAKZiRmwd3KTNMQhm9Bv4oR_1uMehXroO6kGyJQkiw9DfM8cMwQ@mail.gmail.com>
	<CA+TgmoaGeZ=vWDYvWtPY-sP+6594HqLScvPMSSunyuYZVSWMpw@mail.gmail.com>
	<CAKZiRmwTF8mj24f92mh+fiGiceO+myX6CnuYo6u2EJ+ok+Hy4Q@mail.gmail.com>
	<CA+Tgmoar8+V1ycDPgT_-d+1pG_9uRn=qSPty2Y2PgNQBTqRsfQ@mail.gmail.com>

Hello Robert,

20.12.2023 23:56, Robert Haas wrote:
> On Wed, Dec 20, 2023 at 8:11 AM Jakub Wartak
> <jakub.wartak@enterprisedb.com> wrote:
>> the v15 patchset (posted yesterday) test results are GOOD:
> All right. I committed the main two patches, dropped the
> for-testing-only patch, and added a simple test to the remaining
> pg_walsummary patch. That needs more work, but here's what I have as
> of now.

I've found several typos/inconsistencies introduced with 174c48050 and
dc2123400. Maybe you would want to fix them, while on it?:
s/arguent/argument/;
s/BlkRefTableEntry/BlockRefTableEntry/;
s/BlockRefTablEntry/BlockRefTableEntry/;
s/Caonicalize/Canonicalize/;
s/Checksum_Algorithm/Checksum-Algorithm/;
s/corresonding/corresponding/;
s/differenly/differently/;
s/excessing/excessive/;
s/ exta / extra /;
s/hexademical/hexadecimal/;
s/initally/initially/;
s/MAXGPATH/MAXPGPATH/;
s/overrreacting/overreacting/;
s/old_meanifest_file/old_manifest_file/;
s/pg_cominebackup/pg_combinebackup/;
s/pg_tblpc/pg_tblspc/;
s/pointrs/pointers/;
s/Recieve/Receive/;
s/recieved/received/;
s/ recod / record /;
s/ recods / records /;
s/substntially/substantially/;
s/sumamry/summary/;
s/summry/summary/;
s/synchronizaton/synchronization/;
s/sytem/system/;
s/withot/without/;
s/Woops/Whoops/;
s/xlograder/xlogreader/;

Also, a comment above MaybeRemoveOldWalSummaries() basically repeats a
comment above redo_pointer_at_last_summary_removal declaration, but
perhaps it should say about removing summaries instead?

Best regards,
Alexander

view thread (106+ messages)  latest in thread

Message-ID: <061cccf7-0cac-804f-4c2a-9d6da8e3848b@gmail.com>
Permalink:  ../061cccf7-0cac-804f-4c2a-9d6da8e3848b@gmail.com/
Also on:    postgresql.org/message-id/061cccf7-0cac-804f-4c2a-9d6da8e3848b@gmail.com

 ·

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, robertmhaas@gmail.com, jakub.wartak@enterprisedb.com, alvherre@alvh.no-ip.org, andres@anarazel.de, peter@eisentraut.org, dilipbalaut@gmail.com
  Subject: Re: trying again to get incremental backup
  In-Reply-To: <061cccf7-0cac-804f-4c2a-9d6da8e3848b@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox