pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Date: Wed, 26 Dec 2018 14:05:19 +0900
Message-ID: <063eee37-47c2-cd96-d4fd-e742f933e59d@lab.ntt.co.jp> (raw)
In-Reply-To: <20181225052703.GE2334@paquier.xyz>
References: <a1812926-5452-712f-07b0-e347a8a33aca@lab.ntt.co.jp>
	<20181219052705.GD19856@paquier.xyz>
	<830f4ef8-577e-53ed-4017-adad9c21d2e2@lab.ntt.co.jp>
	<20181219092255.GC680@paquier.xyz>
	<1c45ffd5-0a03-7608-43d8-a828253c0c52@lab.ntt.co.jp>
	<20181220013831.GJ27104@paquier.xyz>
	<9e5c22ec-6071-5495-0265-b7a96afb1a15@lab.ntt.co.jp>
	<bcecaf0e-ab92-8271-6887-da213aea9dac@lab.ntt.co.jp>
	<20181221071300.GA1343@paquier.xyz>
	<5be2c21a-9a15-8200-0c76-6bc936ef69f7@lab.ntt.co.jp>
	<20181225052703.GE2334@paquier.xyz>

On 2018/12/25 14:27, Michael Paquier wrote:
> On Tue, Dec 25, 2018 at 10:56:04AM +0900, Tatsuro Yamada wrote:
>> Hmm... Okey, I agree.  Why I implemented the exotic part of the
>> feature is that it is for user-friendly.  However, I suppose that
>> user know the syntax because the syntax is used by an expert user.
> 
> Thanks, I have committed this one after making the logic to ignore
> column numbers a bit smarter, one problem being that "ALTER INDEX foo
> ALTER COLUMN" would try to suggest SET STATISTICS directly, which is
> incorrect.  Instead I have tweaked the completion so as COLUMN is
> added after "ALTER INDEX foo ALTER".  This could be completed later
> with the column numbers, in a way similar to what ALTER TABLE does.
> --
> Michael

Thanks for taking your time! :)

Cheers!
Tatsuro Yamada







view thread (26+ messages)  latest in thread

Message-ID: <063eee37-47c2-cd96-d4fd-e742f933e59d@lab.ntt.co.jp>
Permalink:  ../063eee37-47c2-cd96-d4fd-e742f933e59d@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/063eee37-47c2-cd96-d4fd-e742f933e59d@lab.ntt.co.jp

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: yamada.tatsuro@lab.ntt.co.jp, michael@paquier.xyz, horiguchi.kyotaro@lab.ntt.co.jp, pgsql-hackers@lists.postgresql.org
  Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
  In-Reply-To: <063eee37-47c2-cd96-d4fd-e742f933e59d@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox