From: Jonathan S. Katz <jkatz@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Steven Pousty <steve.pousty@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Isaac Morland <isaac.morland@gmail.com>
Cc: Pierre Giraud <pierre.giraud@dalibo.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Poll: are people okay with function/operator table redesign?
Date: Wed, 29 Apr 2020 19:55:16 -0400
Message-ID: <06f6b32d-a4cc-3723-5bc1-00fa674df961@postgresql.org> (raw)
In-Reply-To: <4894cde4-148d-f0cc-d6d8-182a46f13e1b@postgresql.org>
References: <20200423174343.GA16996@alvherre.pgsql>
<19233.1587665407@sss.pgh.pa.us>
<5561.1587922854@sss.pgh.pa.us>
<13e5e408-bc59-e8ca-44f3-28a981b4fc7d@postgresql.org>
<a47ea348-b9a0-02b7-5bcb-7a32143dd16f@postgresql.org>
<11211.1587951842@sss.pgh.pa.us>
<58de9544-be5b-f325-b5cc-cce4e2dda7d9@postgresql.org>
<5651.1587991781@sss.pgh.pa.us>
<b998a672-2525-1cba-ac64-b292f495919e@postgresql.org>
<30469.1588087170@sss.pgh.pa.us>
<8682.1588202983@sss.pgh.pa.us>
<4894cde4-148d-f0cc-d6d8-182a46f13e1b@postgresql.org>
On 4/29/20 7:40 PM, Jonathan S. Katz wrote:
> On 4/29/20 7:29 PM, Tom Lane wrote:
>> After further fooling with this issue, I've determined that
>>
>> (1) I need to be able to use <programlisting> environments within the
>> func_table_entry cells and have them render more-or-less normally.
>> There doesn't seem to be any other good way to render multiline
>> example results for set-returning functions ... but marking such
>> environments up to the extent that the website style normally does
>> is very distracting.
>>
>> (2) I found that adding !important to the func_table_entry rules
>> is enough to override less-general !important rules. So it'd be
>> possible to leave all the existing CSS rules alone, if that makes
>> you feel more comfortable.
>>
>> The attached updated patch reflects both of these conclusions.
>> We could take out some of the !important annotations here if
>> you're willing to delete !important annotations in more-global
>> rules for <p> and/or <pre>, but maybe that's something to fool
>> with later. I'd like to get this done sooner ...
>
> My preference would be to figure out the CSS rules that are causing you
> to rely on !important at the table level and just fix that up, rather
> than hacking in too many !important.
>
> I'll compromise on the temporary importants, but first I want to see
> what's causing the need for it. Do you have a suggestion on a page to test?
From real quick I got it to here. With the latest copy of the doc builds
it appears to still work as expected, but I need a section with the new
"pre" block to test.
I think the "background-color: inherit !important" is a bit odd, and
would like to trace that one down a bit more, but I did not see anything
obvious on my glance through it.
How does it look on your end?
Jonathan
Attachments:website-style-v3.patch (text/plain, 948B) downloaddiff --git a/media/css/main.css b/media/css/main.cssindex 08ca255..db2670a 100644--- a/media/css/main.css+++ b/media/css/main.css@@ -625,7 +625,7 @@ ul.actions {
}
#docContent p {
- margin-bottom: 1rem !important;+ margin-bottom: 1rem;
}
#docContent hr {
@@ -648,7 +648,7 @@ ul.actions {
}
#docContent pre {
- padding: 0.8rem !important;+ padding: 0.8rem;
}
pre,
@@ -799,6 +799,27 @@ code,
text-align: left;
}
+#docContent table.table th.func_table_entry p,+#docContent table.table td.func_table_entry p {+ margin-top: 0.1em;+ margin-bottom: 0.1em;+ padding-left: 4em;+ text-align: left;+}++#docContent table.table p.func_signature {+ text-indent: -3.5em;+}++#docContent table.table td.func_table_entry pre.programlisting {+ background-color: inherit !important;+ border: 0;+ margin-bottom: 0.1em;+ margin-top: 0.1em;+ padding: 0;+ padding-left: 4em;+}+
/**
* Titles, Navigation
*/
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jkatz@postgresql.org, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, bruce@momjian.us, alvherre@2ndquadrant.com, robertmhaas@gmail.com, steve.pousty@gmail.com, pavel.stehule@gmail.com, isaac.morland@gmail.com, pierre.giraud@dalibo.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Poll: are people okay with function/operator table redesign?
In-Reply-To: <06f6b32d-a4cc-3723-5bc1-00fa674df961@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox