From: David Steele <david@pgmasters.net>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: language cleanups in code and docs
Date: Wed, 8 Jul 2020 17:19:41 -0400
Message-ID: <07e68696-7b45-37cc-4e36-4f682c80cb09@pgmasters.net> (raw)
In-Reply-To: <20200708211756.GA23569@alvherre.pgsql>
References: <20200708211756.GA23569@alvherre.pgsql>
On 7/8/20 5:17 PM, Alvaro Herrera wrote:
> On 2020-Jul-08, David Steele wrote:
>
>> On 7/8/20 4:39 PM, Andres Freund wrote:
>
>> I think this phrasing in the original/updated version is pretty awkward:
>>
>> + A standby server that cannot be connected to until it is promoted to a
>> + primary server is called a ...
>
> Yeah.
>
>> How about:
>>
>> + A standby server that must be promoted to a primary server before
>> + accepting connections is called a ...
>
> How about just reducing it to "A standby server that doesn't accept
> connection is called a ..."? We don't really need to explain that if
> you do promote the standby it will start accept connections -- do we?
> It should be pretty obvious if you promote a standby, it will cease to
> be a standby in the first place. This verbiage seems excessive.
Works for me.
Regards,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, alvherre@2ndquadrant.com, andres@anarazel.de
Subject: Re: language cleanups in code and docs
In-Reply-To: <07e68696-7b45-37cc-4e36-4f682c80cb09@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox