pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Yu Shi (Fujitsu) <shiy.fnst@fujitsu.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
Date: Wed, 3 May 2023 14:16:54 +0200
Message-ID: <083247ee-2366-dd53-803b-0582faa6a52a@gmail.com> (raw )
In-Reply-To: <CAA4eK1+FhvUm6w-TYqXAAMNDPZcin05pyCu7Lzn-AnafFYYhBg@mail.gmail.com >
References: <2fefa454-5a70-2174-ddbf-4a0e41537139@gmail.com >
<CALDaNm2raNJrEF_ucDeTV_AygYutVb1bz2SrKO06YdVVG1gf2A@mail.gmail.com >
<9ab1827c-9a57-8c48-59b2-c5fb62c21be3@gmail.com >
<CAA4eK1KVoAjzT49BwKCih0A+1PE7hm=4PwQ-_VUr9YteFJRB5g@mail.gmail.com >
<CAA4eK1JeAZ9MUf3qPAOA5t9=e_vPJSEi6nZ3OygDYi-913eO+Q@mail.gmail.com >
<74f80bc1-6b39-b2a8-c716-98beefb75e0b@gmail.com >
<OSZPR01MB6310F24417BDD04731BD7978FD659@OSZPR01MB6310.jpnprd01.prod.outlook.com >
<17b6b056-4f53-c444-0c94-869547d1a5df@gmail.com >
<CAA4eK1JiYisk1aqn1uvjd+VCfsVtXLby7uMmkLQU_ggAx7xt6w@mail.gmail.com >
<054defef-de15-53e4-6c5a-d16ccc21d4ba@gmail.com >
<CAA4eK1LEQfC-ZxOkN4=cuAxB1N=2iLcEEb+Mb=XGCqGhwvMkaA@mail.gmail.com >
<8a13f0d8-71f3-773b-7135-5974fd53724b@gmail.com >
<CAA4eK1+FhvUm6w-TYqXAAMNDPZcin05pyCu7Lzn-AnafFYYhBg@mail.gmail.com >
Hi,
On 5/3/23 12:29 PM, Amit Kapila wrote:
> On Tue, May 2, 2023 at 4:52 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>>
>> As per your suggestion, changing the insert ordering (like in V8 attached) makes it now work on the failing environment too.
>>
>
> I think it is better to use wait_for_replay_catchup() to wait for
> standby to catch up.
Oh right, that's a discussion we already had in [1], I should have thought about it.
> I have changed that and a comment in the
> attached. I'll push this tomorrow unless there are further comments.
>
LGTM, thanks!
[1]: https://www.postgresql.org/message-id/acbac69e-9ae8-c546-3216-8ecb38e7a93d%40gmail.com
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
view thread (57+ messages) latest in thread
Message-ID: <083247ee-2366-dd53-803b-0582faa6a52a@gmail.com>
Permalink: ../083247ee-2366-dd53-803b-0582faa6a52a@gmail.com/
Also on: postgresql.org/message-id/083247ee-2366-dd53-803b-0582faa6a52a@gmail.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bertranddrouvot.pg@gmail.com, amit.kapila16@gmail.com, shiy.fnst@fujitsu.com, vignesh21@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
In-Reply-To: <083247ee-2366-dd53-803b-0582faa6a52a@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox