From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Mark Dilger <hornschnorter@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: WIP: BRIN multi-range indexes
Date: Mon, 5 Feb 2018 21:59:48 +0100
Message-ID: <0afde2fc-e160-004f-8fe2-c65302ac3760@2ndquadrant.com> (raw)
In-Reply-To: <104E8BB8-35FF-4AA8-9871-6AFF04E4CAF3@gmail.com>
References: <20180123200537.gfx5hxcp5k5hktpe@alvherre.pgsql>
<821c4c1d-592e-8916-e323-04607b11777e@2ndquadrant.com>
<c32f9f46-e0ca-0c02-45ec-718dd381f4be@2ndquadrant.com>
<104E8BB8-35FF-4AA8-9871-6AFF04E4CAF3@gmail.com>
On 02/05/2018 09:27 PM, Mark Dilger wrote:
>
>> BTW while working on the regression tests, I've noticed that brin.sql
>> fails to test a couple of minmax opclasses (e.g. abstime/reltime). Is
>> that intentional or is that something we should fix eventually?
>
> I believe abstime/reltime are deprecated. Perhaps nobody wanted to
> bother adding test coverage for deprecated classes? There was another
> thread that discussed removing these types. The consensus seemed to
> be in favor of removing them, though I have not seen a patch for that yet.
>
Yeah, that's what I've been wondering about too. There's also this
comment in nabstime.h:
/*
* Although time_t generally is a long int on 64 bit systems, these two
* types must be 4 bytes, because that's what pg_type.h assumes. They
* should be yanked (long) before 2038 and be replaced by timestamp and
* interval.
*/
But then why adding BRIN opclasses at all? And if adding them, why not
to test them? We all know how long deprecation takes, particularly for
data types.
For me the question is whether to bother with adding the multi-minmax
opclasses, of course.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, hornschnorter@gmail.com, alvherre@alvh.no-ip.org
Subject: Re: WIP: BRIN multi-range indexes
In-Reply-To: <0afde2fc-e160-004f-8fe2-c65302ac3760@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox