pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Cc: mitsuru.hinata.5432@gmail.com
Subject: Re: Fix pg_stat_reset_single_table_counters function
Date: Mon, 21 Aug 2023 11:33:28 +0900
Message-ID: <0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com> (raw)
In-Reply-To: <93d14a670cf090c08994f1f4958efa25@oss.nttdata.com>
References: <7cc69f863d9b1bc677544e3accd0e4b4@oss.nttdata.com>
	<9a4a6718abb47647ae83f1f4b3f9bf68@oss.nttdata.com>
	<CAD21AoCnFqzzW7DUW67Art=2w_Z3gwKU1suSn0d0UtUPtdbt_g@mail.gmail.com>
	<20230812191207.aerskqox7aoan3ud@awork3.anarazel.de>
	<97c9f7a46681f051b1356e2987c3fd6c@oss.nttdata.com>
	<CAD21AoDhhdicG3rYwKq3fLngn=T4qRuFiOWtqeYFwMM_-R43WQ@mail.gmail.com>
	<93d14a670cf090c08994f1f4958efa25@oss.nttdata.com>

Apologies. In the previous mail, I mistakenly addressed it to the wrong 
recipients. Reposted.

On 2023/08/15 14:13, Masahiro Ikeda wrote:
> On 2023-08-15 11:48, Masahiko Sawada wrote:
>> +COMMENT ON DATABASE :current_database IS 'This is a test comment';
>> -- insert or update in 'pg_shdescription'
>>
>> I think the current_database should be quoted (see other examples
>> where using current_database(), e.g. collate.linux.utf8.sql). Also it
>> would be better to reset the comment after the test.
>
> Thanks! I fixed the issues in the v4 patch.

I'm not sure about others, but I would avoid using the name 
"current_database" for the variable.

I would just use "database" or "db" instead.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center






view thread (11+ messages)  latest in thread

Message-ID: <0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com>
Permalink:  ../0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com/
Also on:    postgresql.org/message-id/0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: horikyota.ntt@gmail.com, ikedamsh@oss.nttdata.com, sawada.mshk@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, mitsuru.hinata.5432@gmail.com
  Subject: Re: Fix pg_stat_reset_single_table_counters function
  In-Reply-To: <0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox