pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Cc: mitsuru.hinata.5432@gmail.com
Subject: Re: Fix pg_stat_reset_single_table_counters function
Date: Mon, 21 Aug 2023 13:38:45 +0900
Message-ID: <a66ff7ca6f4349f8629a35379c5937ca@oss.nttdata.com> (raw)
In-Reply-To: <ZOLpUtMeq8rg8JWk@paquier.xyz>
References: <7cc69f863d9b1bc677544e3accd0e4b4@oss.nttdata.com>
	<9a4a6718abb47647ae83f1f4b3f9bf68@oss.nttdata.com>
	<CAD21AoCnFqzzW7DUW67Art=2w_Z3gwKU1suSn0d0UtUPtdbt_g@mail.gmail.com>
	<20230812191207.aerskqox7aoan3ud@awork3.anarazel.de>
	<97c9f7a46681f051b1356e2987c3fd6c@oss.nttdata.com>
	<CAD21AoDhhdicG3rYwKq3fLngn=T4qRuFiOWtqeYFwMM_-R43WQ@mail.gmail.com>
	<93d14a670cf090c08994f1f4958efa25@oss.nttdata.com>
	<0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com>
	<ZOLpUtMeq8rg8JWk@paquier.xyz>

On 2023-08-21 13:34, Michael Paquier wrote:
> On Mon, Aug 21, 2023 at 11:33:28AM +0900, Kyotaro Horiguchi wrote:
>> I'm not sure about others, but I would avoid using the name
>> "current_database" for the variable.
> 
> Agreed.  Looking at the surroundings, we have for example "datname" in
> the collation tests so I have just used that, and applied the patch
> down to 15.

Thanks!

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION





view thread (11+ messages)

Message-ID: <a66ff7ca6f4349f8629a35379c5937ca@oss.nttdata.com>
Permalink:  ../a66ff7ca6f4349f8629a35379c5937ca@oss.nttdata.com/
Also on:    postgresql.org/message-id/a66ff7ca6f4349f8629a35379c5937ca@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ikedamsh@oss.nttdata.com, michael@paquier.xyz, horikyota.ntt@gmail.com, sawada.mshk@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, mitsuru.hinata.5432@gmail.com
  Subject: Re: Fix pg_stat_reset_single_table_counters function
  In-Reply-To: <a66ff7ca6f4349f8629a35379c5937ca@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox