public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yuchen Li <[email protected]>
To: Daniel Westermann (DWE) <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Re: docs: Fix format of CREATE FOREIGN TABLE example in postgres_fdw
Date: Thu, 16 Apr 2026 17:17:24 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <ZR2PPFF1830B8773AC9735393FFF93F8665D2222@ZR2PPFF1830B877.CHEP278.PROD.OUTLOOK.COM>
References: <ZR2PPFF1830B8773AC9735393FFF93F8665D2222@ZR2PPFF1830B877.CHEP278.PROD.OUTLOOK.COM>

On 4/15/2026 5:27 PM, Daniel Westermann (DWE) wrote:
> Hi,
>
> while reading https://www.postgresql.org/docs/devel/postgres-fdw.html 
> <https://www.postgresql.org/docs/devel/postgres-fdw.html; I've noticed 
> that there is a single bracket on one line of the CREATE FOREIGN TABLE 
> example.
>
> Browsing through other docs (e,g. 
> https://www.postgresql.org/docs/devel/sql-createtable.html 
> <https://www.postgresql.org/docs/devel/sql-createtable.html> ) there 
> doesn't seem to be a rule for that but if there is a single bracket 
> (e.g. CREATE TABLE distributors), the options that follow usually 
> start at position one and are not indented (or they follow directly 
> after the bracket).
>
> The examples in file_fdw 
> (https://www.postgresql.org/docs/devel/file-fdw.html) follow a mix of 
> options which directly follow the bracket and on a new line.
>
> Attached a small patch which makes it looking a bit better, at least 
> in my opinion.
>
> Regards
> Daniel

While looking through the patch, I noticed a small formatting issue in
the following part:

+)
+SERVER foreign_server
+OPTIONS (schema_name 'some_schema', table_name 'some_table');

The added +) line appears to have a trailing space after the closing
parenthesis.

Regards,
Yuchen Li

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: docs: Fix format of CREATE FOREIGN TABLE example in postgres_fdw
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox