From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: LogicalChanges* and LogicalSubxact* wait events are never reported
Date: Fri, 22 Oct 2021 09:38:57 +0900
Message-ID: <102b9e3c-fa5f-9807-e817-6e9e55fdaff6@oss.nttdata.com> (raw)
In-Reply-To: <CAA4eK1LDaev5zVSav7PvaYBbNeK1sPA4XcxCCpfsd8HkUxa6Xg@mail.gmail.com>
References: <ff077840-3ab2-04dd-bbe4-4f5dfd2ad481@oss.nttdata.com>
<YW+nFebbUI9/LuLw@paquier.xyz>
<CAA4eK1LNBQtcywY7-YHKBuLV3TfGn8E_uAXMDDi9j4TE0O0Bww@mail.gmail.com>
<3d68e948-e1ae-bb27-94da-43863ec3ace3@oss.nttdata.com>
<CAA4eK1LDaev5zVSav7PvaYBbNeK1sPA4XcxCCpfsd8HkUxa6Xg@mail.gmail.com>
On 2021/10/21 17:40, Amit Kapila wrote:
> On Wed, Oct 20, 2021 at 3:46 PM Masahiro Ikeda <ikedamsh@oss.nttdata.com> wrote:
>>
>> On 2021/10/20 18:17, Amit Kapila wrote:
>>> On Wed, Oct 20, 2021 at 10:50 AM Michael Paquier <michael@paquier.xyz> wrote:
>>>>
>>>> On Wed, Oct 20, 2021 at 02:12:20PM +0900, Masahiro Ikeda wrote:
>>>>> If my understanding is right, it's better to remove them since they make
>>>>> users confused. Please see the attached patch. I confirmed that to make
>>>>> check-world passes all tests.
>>>>
>>>> Yeah, I don't see the point in keeping these events around if they are
>>>> not used. Perhaps Amit has some plans for them, though.
>>>>
>>>
>>> No, there is no plan for these. As far as I remember, during
>>> development, we have decided to use BufFile interface and forgot to
>>> remove these events which were required by the previous versions of
>>> the patch. I'll take care of this.
>>>
>>> Thanks for the report and patch!
>> Thanks for your replies and for handling it!
>>
>
> Pushed!
Thanks!
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ikedamsh@oss.nttdata.com, amit.kapila16@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: LogicalChanges* and LogicalSubxact* wait events are never reported
In-Reply-To: <102b9e3c-fa5f-9807-e817-6e9e55fdaff6@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox