pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Martín Marqués <martin@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Read access for pg_monitor to pg_replication_origin_status view
Date: Mon, 15 Jun 2020 00:44:02 -0400
Message-ID: <1098356.1592196242@sss.pgh.pa.us> (raw)
In-Reply-To: <20200614034540.GB1496@paquier.xyz>
References: <20200604.161033.1845732016784727041.horikyota.ntt@gmail.com>
	<CAPdiE1wUt3WQZq30Wa1Xz0NM7rtVPZdK15PKRd0zS3ugZsCsow@mail.gmail.com>
	<CA+fd4k6ybp7M=GXKrJG0h4eg9XehmtGtKBxwwA9auHUuTNk+Kg@mail.gmail.com>
	<20200608.174456.238992210909952383.horikyota.ntt@gmail.com>
	<20200609061104.GD38342@paquier.xyz>
	<CA+fd4k68H8bPCyq7RggEjyvvag47gG61-wXQm_sSOzvovP+Fhg@mail.gmail.com>
	<20200609073555.GF38342@paquier.xyz>
	<CA+fd4k6OuoNteNo3oAK0snobR0i7rr+88S96GkTH0KjVJ0ZYMg@mail.gmail.com>
	<20200610033549.GH38342@paquier.xyz>
	<20200614034540.GB1496@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Jun 10, 2020 at 12:35:49PM +0900, Michael Paquier wrote:
>> OK, thanks.  Then let's wait a couple of days to see if anybody has
>> any objections with the removal of the hardcoded superuser check
>> for those functions.

> Committed the part removing the superuser checks as of cc07264.

FWIW, I'd have included a catversion bump in this, to enforce that
the modified backend functions are used with matching pg_proc entries.
It's not terribly important at this phase of the devel cycle, but still
somebody might wonder why the regression tests are failing for them
(if they tried to skip an initdb).

			regards, tom lane





view thread (31+ messages)  latest in thread

Message-ID: <1098356.1592196242@sss.pgh.pa.us>
Permalink:  ../1098356.1592196242@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1098356.1592196242@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, masahiko.sawada@2ndquadrant.com, horikyota.ntt@gmail.com, martin@2ndquadrant.com, sfrost@snowman.net
  Subject: Re: Read access for pg_monitor to pg_replication_origin_status view
  In-Reply-To: <1098356.1592196242@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox