pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
Date: Thu, 24 Jan 2019 11:35:25 -0500
Message-ID: <11057.1548347725@sss.pgh.pa.us> (raw)
In-Reply-To: <alpine.DEB.2.21.1901222007100.16643@lancre>
References: <9427.1547701450@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901170659210.7416@lancre>
	<21538.1547770868@sss.pgh.pa.us>
	<4615.1547792324@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901180926580.26418@lancre>
	<29225.1547834182@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901182257480.20734@lancre>
	<alpine.DEB.2.21.1901201051270.14950@lancre>
	<7879.1548015981@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901202225310.28945@lancre>
	<9718.1548175497@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901222007100.16643@lancre>

Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> I had in mind something more like the attached.

> Yep.
> I'm not too happy that it mixes API levels, and about the int/double/int 
> path.
> Attached an updated version which relies on pg_jrand48 instead.

Hm, I'm not sure that's really an improvement, but I pushed it like that
(and the other change along with it).

> Also, as 
> the pseudo-random state is fully controlled, seeded test results are 
> deterministic so the expected value can be fully checked.

I found that the "expected value" was different in v11 than HEAD,
which surprised me.  It looks like the reason is that HEAD sets up
more/different RandomStates from the same seed than v11 did.  Not
sure if it's a good thing for this behavior to change across versions.

			regards, tom lane




view thread (37+ messages)  latest in thread

Message-ID: <11057.1548347725@sss.pgh.pa.us>
Permalink:  ../11057.1548347725@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/11057.1548347725@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, pgsql-hackers@lists.postgresql.org
  Subject: Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
  In-Reply-To: <11057.1548347725@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox