From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Superuser can permit passwordless connections on postgres_fdw
Date: Fri, 20 Dec 2019 22:17:20 -0500
Message-ID: <11100.1576898240@sss.pgh.pa.us> (raw)
In-Reply-To: <20191221021806.GA15758@paquier.xyz>
References: <E1iiBFm-0001RN-N2@gemulon.postgresql.org>
<20191220120208.GA4258@paquier.xyz>
<11297.1576868677@sss.pgh.pa.us>
<32150.1576870942@sss.pgh.pa.us>
<20191221021806.GA15758@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Dec 20, 2019 at 02:42:22PM -0500, Tom Lane wrote:
>> I notice in testing this that the "nosuper" business added by
>> 6136e94dc is broken in more ways than what the buildfarm is
>> complaining about: it leaves the role around at the end of the
>> test.
> Roles left behind at the end of a test are annoying. Here is an idea:
> make pg_regress check if any roles prefixed by "regress_" are left
> behind at the end of a test. This will not work until test_pg_dump is
> cleaned up, just a thought.
Yeah, it's sort of annoying that the buildfarm didn't notice this
aspect of things. I'm not sure I want to spend cycles on checking
it in every test run, though.
Maybe we could have -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS
enable a check for that aspect along with what it does now?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Superuser can permit passwordless connections on postgres_fdw
In-Reply-To: <11100.1576898240@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox