From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Bizarre choice of case for RELKIND_PARTITIONED_TABLE
Date: Tue, 07 Mar 2017 19:02:04 -0500
Message-ID: <11145.1488931324@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmobWQVuVkO9cRxA7=7kMLaYSUmZb_kS6M7eC+sk0qv8LPA@mail.gmail.com>
References: <27899.1488909319@sss.pgh.pa.us>
<CA+TgmoaAgj-3gerC=ZE5dU8Vpz-tDt0FAcpLomajOVsOe0vrzw@mail.gmail.com>
<8913.1488927818@sss.pgh.pa.us>
<CA+TgmobWQVuVkO9cRxA7=7kMLaYSUmZb_kS6M7eC+sk0qv8LPA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Mar 7, 2017 at 6:03 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm, one would hope that the vast majority of code references are neither
>> of those, but rather "RELKIND_PARTITIONED_TABLE".
> For reasons which must've seemed good to whoever instituted the
> policy, pg_dump refers to relkinds using the bare letters rather than
> the constants.
Even in pg_dump, it appears to me that the large majority of relkind
references use the symbolic names. Quite a few of the violations of
that policy look to be new ... and now that I see them, their days are
numbered.
> (And protocol message types don't even have defined constants. Uggh.)
Yeah, that's a different issue, which boils down to the fact that in order
to do anything useful we'd need to clutter client-visible namespace with
the symbols. I wouldn't be averse to doing something about it as long as
it's not done in postgres_ext.h, but if not there where?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: Bizarre choice of case for RELKIND_PARTITIONED_TABLE
In-Reply-To: <11145.1488931324@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox