From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Bizarre choice of case for RELKIND_PARTITIONED_TABLE
Date: Tue, 07 Mar 2017 18:03:38 -0500
Message-ID: <8913.1488927818@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoaAgj-3gerC=ZE5dU8Vpz-tDt0FAcpLomajOVsOe0vrzw@mail.gmail.com>
References: <27899.1488909319@sss.pgh.pa.us>
<CA+TgmoaAgj-3gerC=ZE5dU8Vpz-tDt0FAcpLomajOVsOe0vrzw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Mar 7, 2017 at 12:55 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Is there a good reason why RELKIND_PARTITIONED_TABLE is 'P' not 'p'?
> I can't muster a lot of outrage about this one way or another. One
> possible advantage of 'P' is that there are fewer places where 'P' is
> mentioned in the source code than 'p'.
Hm, one would hope that the vast majority of code references are neither
of those, but rather "RELKIND_PARTITIONED_TABLE". information_schema.sql
and system_views.sql will need to be gone over carefully, certainly, but
we shouldn't be hard-coding this anywhere that there's a reasonable
alternative.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: Bizarre choice of case for RELKIND_PARTITIONED_TABLE
In-Reply-To: <8913.1488927818@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox