pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: Jelte Fennema <Jelte.Fennema@microsoft.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Merlin Moncure <mmoncure@gmail.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Subject: Re: [PATCH] Optimize json_lex_string by batching character copying
Date: Mon, 11 Jul 2022 11:53:26 -0400
Message-ID: <1119852.1657554806@sss.pgh.pa.us> (raw)
In-Reply-To: <20220711154150.hwzw7qw2k6iahofy@awork3.anarazel.de>
References: <PR3PR83MB0476F098CBCF68AF7A1CA89FF7B49@PR3PR83MB0476.EURPRD83.prod.outlook.com>
	<20220625001810.q4giojmraweoyl5e@alap3.anarazel.de>
	<20220625010551.r5qrk5n2euuwqos3@alap3.anarazel.de>
	<CAFBsxsGhaR2KQ5eisaK=6Vm60t=axhD8Ckj1qFoCH1pktZi+2w@mail.gmail.com>
	<20220706051801.gfbzjxgflbsglyt6@awork3.anarazel.de>
	<CAFBsxsE0FkMT0vZOLfJEOCM1Di81Wy_5fE9S1rn0PNHMYrmCCw@mail.gmail.com>
	<20220711154150.hwzw7qw2k6iahofy@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> I wonder if we can't abstract this at least a bit better. If we go that route
> a bit further, then add another arch, this code will be pretty much
> unreadable.

IMO, it's pretty unreadable *now*, for lack of comments about what it's
doing and why.

			regards, tom lane





view thread (37+ messages)  latest in thread

Message-ID: <1119852.1657554806@sss.pgh.pa.us>
Permalink:  ../1119852.1657554806@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1119852.1657554806@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, john.naylor@enterprisedb.com, Jelte.Fennema@microsoft.com, mmoncure@gmail.com, andrew.dunstan@2ndquadrant.com, sfrost@snowman.net
  Subject: Re: [PATCH] Optimize json_lex_string by batching character copying
  In-Reply-To: <1119852.1657554806@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox