pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
Date: Thu, 02 May 2019 17:12:03 -0400
Message-ID: <11237.1556831523@sss.pgh.pa.us> (raw)
In-Reply-To: <20190502210253.lt4p46dvllxarajg@alap3.anarazel.de>
References: <27459.1556762513@sss.pgh.pa.us>
	<20190502021913.axyvyyyw5547swy5@alap3.anarazel.de>
	<25661.1556808540@sss.pgh.pa.us>
	<20190502153107.o5zadep4ehebzoqy@alap3.anarazel.de>
	<4870.1556811688@sss.pgh.pa.us>
	<20190502155612.ep5wqyninmkrz6uh@alap3.anarazel.de>
	<5531.1556812964@sss.pgh.pa.us>
	<2157.1556816395@sss.pgh.pa.us>
	<20190502172851.klckhiyukqd3bd2t@alap3.anarazel.de>
	<10650.1556830451@sss.pgh.pa.us>
	<20190502210253.lt4p46dvllxarajg@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-02 16:54:11 -0400, Tom Lane wrote:
>> How do you feel about the other patch to rejigger the order of operations
>> in CommandCounterIncrement?  I think that's a bug, but it's probably
>> noncritical for most people.  What I'm leaning towards for that one is
>> waiting till after the minor releases, then pushing it to all branches.

> I've not yet have the mental cycles to look more deeply into it. I
> thought your explanation why the current way is wrong made sense, but I
> wanted to look a bit more into how it came to be how it is now.

Well, I wrote that code, and I can say pretty confidently that this
failure mode just didn't occur to me at the time.

> I agree
> that pushing after the minors would make sense, it's too subtle to go
> for it now.

It is subtle, and given that it's been there this long, I don't feel
urgency to fix it Right Now.  I think we're already taking plenty of
risk back-patching the REINDEX patch :-(

			regards, tom lane





view thread (82+ messages)  latest in thread

Message-ID: <11237.1556831523@sss.pgh.pa.us>
Permalink:  ../11237.1556831523@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/11237.1556831523@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
  In-Reply-To: <11237.1556831523@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox