From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
Date: Thu, 02 May 2019 10:49:00 -0400
Message-ID: <25661.1556808540@sss.pgh.pa.us> (raw)
In-Reply-To: <20190502021913.axyvyyyw5547swy5@alap3.anarazel.de>
References: <28926.1556664156@sss.pgh.pa.us>
<20190430225307.lvfvcf2776iywhw4@alap3.anarazel.de>
<20190501013638.7u7fwr4zktbyyng5@alap3.anarazel.de>
<25049.1556727622@sss.pgh.pa.us>
<20190501170603.hx6r3ztyvi3rlgq6@alap3.anarazel.de>
<20190501172115.4cvz3rp6np43odut@alap3.anarazel.de>
<5483.1556737736@sss.pgh.pa.us>
<16043.1556754084@sss.pgh.pa.us>
<20190502012520.eyfhhn5ix2ooflys@alap3.anarazel.de>
<27459.1556762513@sss.pgh.pa.us>
<20190502021913.axyvyyyw5547swy5@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2019-05-01 22:01:53 -0400, Tom Lane wrote:
>> I think that argument is pretty pointless considering that "REINDEX TABLE
>> pg_class" does it this way, and that code is nearly old enough to
>> vote.
> IMO the reindex_relation() case isn't comparable.
IMV it's the exact same case: we need to perform a pg_class update while
one or more of pg_class's indexes shouldn't be touched. I am kind of
wondering why it didn't seem to be necessary to cover this for REINDEX
INDEX back in 2003, but it clearly is necessary now.
> That's not pretty either :(
So, I don't like your patch, you don't like mine. Anybody else
want to weigh in?
We do not have the luxury of time to argue about this. If we commit
something today, we *might* get a useful set of CLOBBER_CACHE_ALWAYS
results for all branches by Sunday. Those regression tests will have to
come out of the back branches on Sunday, because we are not shipping minor
releases with unstable regression tests, and I've heard no proposal for
avoiding the occasional-deadlock problem.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
In-Reply-To: <25661.1556808540@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox