pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: WRITE_*_ARRAY macros for outfuncs.c
Date: Wed, 19 Dec 2018 12:11:08 -0500
Message-ID: <11307.1545239468@sss.pgh.pa.us> (raw)
In-Reply-To: <8f2ebc67-e75f-9478-f5a5-bbbf090b1f8d@2ndquadrant.com>
References: <8f2ebc67-e75f-9478-f5a5-bbbf090b1f8d@2ndquadrant.com>

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> In readfuncs.c, we have READ_ATTRNUMBER_ARRAY, READ_OID_ARRAY,
> READ_INT_ARRAY, READ_BOOL_ARRAY, but the writing side in outfuncs.c is
> coded by hand in each case.  Any reason for this?

> Here is a patch that adds WRITE_ATTRNUMBER_ARRAY, WRITE_OID_ARRAY,
> WRITE_INT_ARRAY, WRITE_BOOL_ARRAY.  That seems much nicer.

LGTM.

			regards, tom lane




view thread (2+ messages)

Message-ID: <11307.1545239468@sss.pgh.pa.us>
Permalink:  ../11307.1545239468@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/11307.1545239468@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
  Subject: Re: WRITE_*_ARRAY macros for outfuncs.c
  In-Reply-To: <11307.1545239468@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox