From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields
Date: Thu, 12 Jan 2023 12:23:29 -0500
Message-ID: <1144412.1673544209@sss.pgh.pa.us> (raw)
In-Reply-To: <20230112171252.xucefmthy5l4l2ec@alvherre.pgsql>
References: <20230112171252.xucefmthy5l4l2ec@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I don't like this at all. With these prefixes in place, it's much more
> likely that you'll be able to grep the whole source tree and not run
> into tons of false positives. If you remove them, that tends to be not
> very workable. If we use these commits as precedent for expanding this
> sort of renaming across the tree, we'll soon end up with a very
> grep-unfriendly code base.
+1, that was my immediate fear as well.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, bertranddrouvot.pg@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields
In-Reply-To: <1144412.1673544209@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox