pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Antonin Houska <ah@cybertec.at>
To: pgsql-hackers@postgresql.org
Subject: Inaccurate header comment of issue_xlog_fsync_comment
Date: Mon, 20 May 2019 16:03:40 +0200
Message-ID: <11863.1558361020@spoje.net> (raw)

Someone probably forgot to update the comment when changing the arguments.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

Attachments:

  [text/x-diff] issue_xlog_fsync_comment.patch (570B, ../11863.1558361020@spoje.net/2-issue_xlog_fsync_comment.patch)
  download | inline diff:
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index c00b63c751..527522f165 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -10065,7 +10065,7 @@ assign_xlog_sync_method(int new_sync_method, void *extra)
  * Issue appropriate kind of fsync (if any) for an XLOG output file.
  *
  * 'fd' is a file descriptor for the XLOG file to be fsync'd.
- * 'log' and 'seg' are for error reporting purposes.
+ * 'segno' is for error reporting purposes.
  */
 void
 issue_xlog_fsync(int fd, XLogSegNo segno)

view thread (2+ messages)  latest in thread

Message-ID: <11863.1558361020@spoje.net>
Permalink:  ../11863.1558361020@spoje.net/
Also on:    postgresql.org/message-id/11863.1558361020@spoje.net

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ah@cybertec.at
  Subject: Re: Inaccurate header comment of issue_xlog_fsync_comment
  In-Reply-To: <11863.1558361020@spoje.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox