pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedInaccurate header comment of issue_xlog_fsync_comment
2+ messages / 2 participants
[nested] [flat]
* Inaccurate header comment of issue_xlog_fsync_comment
@ 2019-05-20 14:03 Antonin Houska <ah@cybertec.at>
2019-05-20 16:44 ` Re: Inaccurate header comment of issue_xlog_fsync_comment Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: Antonin Houska @ 2019-05-20 14:03 UTC (permalink / raw)
To: pgsql-hackers
Someone probably forgot to update the comment when changing the arguments.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
Attachments:
[text/x-diff] issue_xlog_fsync_comment.patch (570B, ../../11863.1558361020@spoje.net/2-issue_xlog_fsync_comment.patch)
download | inline diff:
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index c00b63c751..527522f165 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -10065,7 +10065,7 @@ assign_xlog_sync_method(int new_sync_method, void *extra)
* Issue appropriate kind of fsync (if any) for an XLOG output file.
*
* 'fd' is a file descriptor for the XLOG file to be fsync'd.
- * 'log' and 'seg' are for error reporting purposes.
+ * 'segno' is for error reporting purposes.
*/
void
issue_xlog_fsync(int fd, XLogSegNo segno)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Inaccurate header comment of issue_xlog_fsync_comment
2019-05-20 14:03 Inaccurate header comment of issue_xlog_fsync_comment Antonin Houska <ah@cybertec.at>
@ 2019-05-20 16:44 ` Fujii Masao <masao.fujii@gmail.com>
0 siblings, 0 replies; 2+ messages in thread
From: Fujii Masao @ 2019-05-20 16:44 UTC (permalink / raw)
To: Antonin Houska <ah@cybertec.at>; +Cc: pgsql-hackers
On Mon, May 20, 2019 at 11:04 PM Antonin Houska <ah@cybertec.at> wrote:
>
> Someone probably forgot to update the comment when changing the arguments.
Thanks for the patch! Committed.
Regards,
--
Fujii Masao
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-05-20 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20 14:03 Inaccurate header comment of issue_xlog_fsync_comment Antonin Houska <ah@cybertec.at>
2019-05-20 16:44 ` Fujii Masao <masao.fujii@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox