From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: need xmllint on borka
Date: Tue, 06 May 2014 23:22:09 -0400
Message-ID: <12100.1399432929@sss.pgh.pa.us> (raw)
In-Reply-To: <1399429219.5361.10.camel@vanquo.pezone.net>
References: <1398996306.13844.3.camel@vanquo.pezone.net>
<11463.1398999091@sss.pgh.pa.us>
<1399429219.5361.10.camel@vanquo.pezone.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Peter Eisentraut <peter_e@gmx.net> writes:
> On Thu, 2014-05-01 at 22:51 -0400, Tom Lane wrote:
>> -1. Doesn't this break "make man" for *any* hacker who doesn't have
>> xmllint installed?
> The intention is that we enforce that the documentation is correctly
> formatted. Enforcing that only when the required tool is installed is
> the same as not enforcing it and annoying those who happen to have the
> tool installed.
Okay, but if that's the intent I suggest that the check needs to happen
somewhere more prominent than in nondefault build targets. Personally,
I run "make man" about once a release cycle, if that often; and I'm not
sure I've ever built any of the other targets modified in this patch.
If you want to enforce correctness then I think you should put the xmllint
call into the "make all" path, which would render all of the targets
touched here rather redundant.
Also, in the vein of "is this a full-scale build requirement or not",
why is the pathname of xmllint just hard-coded into the makefile and
not something that's checked for by configure?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter_e@gmx.net
Subject: Re: need xmllint on borka
In-Reply-To: <12100.1399432929@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox