pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org, Jacob Champion <jchampion@timescale.com>
Subject: Re: [PATCH] minor reloption regression tests improvement
Date: Thu, 30 Jun 2022 07:04:25 +0300
Message-ID: <12182567.IpiZAh8j0P@thinkpad-pgpro> (raw)
In-Reply-To: <2590342.64y9vfTr7p@thinkpad-pgpro>
References: <4563991.km65PDbjlG@thinkpad-pgpro>
	<165653872847.1152.5920509051824255715.pgcf@coridan.postgresql.org>
	<2590342.64y9vfTr7p@thinkpad-pgpro>

В письме от четверг, 30 июня 2022 г. 06:47:48 MSK пользователь Nikolay Shaplov 
написал:
 
> Hi! I am surely feel this patch is important. I have bigger patch
> https://commitfest.postgresql.org/38/3536/ and this test makes sense as a
> part of big work of options refactoring,
> 
> I am also was strongly advised to commit things chopped into smaller parts,
> when possible. This test can be commit separately so I am doing it.

Let me again explain why this test is importaint, so potential reviewers can 
easily find this information.

Tests are for developers. You change the code and see that something does not 
work anymore, as it worked before.
When you change the code, you should keep both documented and undocumented 
behaviour. Because user's code can intentionally  or accidentally use it. 

So known undocumented behavior is better to be tested as well as documented 
one. If you as developer want to change undocumented behavior, it is better to 
do it consciously. This test insures that.

I, personally hit this problem while working with reloption code. Older 
version of my new patch changed this behaviour, and I even did not notice 
that. So I decided to write this test to ensure, that nobody ever meet same 
problem. 

And as I said before, I was strongly advised to commit in small parts, when 
possible. This test can be commit separately.  

-- 
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

Attachments:

  signature.asc (application/pgp-signature, 487B) download

view thread (9+ messages)  latest in thread

Message-ID: <12182567.IpiZAh8j0P@thinkpad-pgpro>
Permalink:  ../12182567.IpiZAh8j0P@thinkpad-pgpro/
Also on:    postgresql.org/message-id/12182567.IpiZAh8j0P@thinkpad-pgpro

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: dhyan@nataraj.su, jchampion@timescale.com
  Subject: Re: [PATCH] minor reloption regression tests improvement
  In-Reply-To: <12182567.IpiZAh8j0P@thinkpad-pgpro>
  References: <4563991.km65PDbjlG@thinkpad-pgpro> <165653872847.1152.5920509051824255715.pgcf@coridan.postgresql.org> <2590342.64y9vfTr7p@thinkpad-pgpro> <12182567.IpiZAh8j0P@thinkpad-pgpro>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox