agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Mon, 05 Jan 2026 11:54:07 +0100
Message-ID: <12236.1767610447@localhost> (raw)
In-Reply-To: <CADzfLwWNz_jwi7KVOmJ9D97+zwxsiwDSqSUUJ9oqUCOqkbGnRA@mail.gmail.com>
References: <202510301734.pj4uds3mqxx4@alvherre.pgsql>
<116433.1764870207@localhost>
<CADzfLwWFbXVN-QrKaVXvW96eYQD1AiRVCYd99nX7EQFG3q_yfg@mail.gmail.com>
<CADzfLwWS6Ukme5uhv9=1ZyyG=D5Bp0dE+zGn=qcfGV=jSY6mpw@mail.gmail.com>
<CADzfLwXudUtPi1xFC_CBpGP=vSmDY4pAvBbS4_BCwOUyNTT5WA@mail.gmail.com>
<171530.1765306357@localhost>
<CADzfLwXp4c-MJx7yVDxAGNNxPbX4o9dqyivxavtHvmUsdXYqBQ@mail.gmail.com>
<CADzfLwUitd5J17O9FUxNGrZBurOpL6n+tnS6dgArXi-i9DNxhg@mail.gmail.com>
<CADzfLwWNz_jwi7KVOmJ9D97+zwxsiwDSqSUUJ9oqUCOqkbGnRA@mail.gmail.com>
Mihail Nikalayeu <mihailnikalayeu@gmail.com> wrote:
> Hello!
>
> On Sat, Dec 13, 2025 at 7:45 PM Mihail Nikalayeu
> <mihailnikalayeu@gmail.com> wrote:
> > Stress tests for REPACK concurrently in attachment.
>
> To run:
> ninja && meson test --suite setup && meson test --print-errorlogs
> --suite amcheck *007*
> ninja && meson test --suite setup && meson test --print-errorlogs
> --suite amcheck *008*
Thanks for running the tests!
> Results for v28:
>
> Up to " v28-0005-Use-background-worker-to-do-logical-decoding.patch":
>
> Technically it passes, but sometimes I saw 0% CPU usage for long
> periods with such stacks (looks like it happens for 0008 more often):
...
> Probably it is because
> > 100000L, /* XXX Tune the delay. */
>
> 100 seconds is clearly too much.
I confused milliseconds with microseconds. Since I was only running the code
with debugger, the long delays didn't appear to be a problem.
Instead of tuning the timeout, I'm thinking of introducing a condition
variable that signals WAL flushing.
> For "v28-0006-Use-multiple-snapshots-to-copy-the-data.patch":
>
> 0007: crash with
>
> TRAP: failed Assert("portal->portalSnapshot == GetActiveSnapshot()"),
> File: "../src/backend/tcop/pquery.c", Line: 1169, PID: 178414
Thanks. I'll check when I have time for this part.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (416+ messages) latest in thread
Message-ID: <12236.1767610447@localhost>
Permalink: ../12236.1767610447@localhost/
Also on: postgresql.org/message-id/12236.1767610447@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, mihailnikalayeu@gmail.com, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <12236.1767610447@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox