From: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
Date: Wed, 07 Mar 2018 18:23:03 +0300
Message-ID: <12291633.PFnvXaAOpE@x200m> (raw)
In-Reply-To: <20180301174735.yyu6i5y66u3xp3jc@alvherre.pgsql>
References: <20180301174735.yyu6i5y66u3xp3jc@alvherre.pgsql>
В письме от 1 марта 2018 14:47:35 пользователь Alvaro Herrera написал:
> I see you lost the Oxford comma:
>
> -DETAIL: Valid values are "on", "off", and "auto".
> +DETAIL: Valid values are "auto", "on" and "off".
>
> Please put these back.
Actually that's me who have lost it. The code with oxford comma would be a
bit more complicated. We should put such coma when we have 3+ items and do not
put it when we have 2.
Does it worth it?
As I've read oxford using of comma is not mandatory and used to avoid
ambiguity.
"XXX, YYY and ZZZ" can be read as "XXX, YYY, ZZZ" or as "XXX, (YYY and ZZZ)".
oxford comma is used to make sure that YYY and ZZZ are separate items of the
list, not an expression inside one item.
But here we hardly have such ambiguity.
So I'll ask again, do you really think it worth it?
--
Do code for fun.
Attachments:
[application/pgp-signature] signature.asc (472B, ../12291633.PFnvXaAOpE@x200m/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org, alvherre@alvh.no-ip.org, n.gluhov@postgrespro.ru
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
In-Reply-To: <12291633.PFnvXaAOpE@x200m>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox