From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Radix tree for character conversion
Date: Fri, 07 Oct 2016 12:19:23 -0400
Message-ID: <12566.1475857163@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoYj5DhfCyWosYCgcCFP8pPjvhpYsGFFpVWVbdPnT9JM7w@mail.gmail.com>
References: <20160908.153546.187438961.horiguchi.kyotaro@lab.ntt.co.jp>
<7ff67a45-a53e-4d38-e25d-3a121afea47c@iki.fi>
<20160921.151427.265121484.horiguchi.kyotaro@lab.ntt.co.jp>
<20161007.173606.217452136.horiguchi.kyotaro@lab.ntt.co.jp>
<af224134-80dc-b18e-54f8-d45504754fc0@iki.fi>
<CA+TgmoYj5DhfCyWosYCgcCFP8pPjvhpYsGFFpVWVbdPnT9JM7w@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Oct 7, 2016 at 6:46 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> Ouch. We should find and document an authoritative source for all the
>> mappings we have...
>>
>> I think the next steps here are:
>>
>> 1. Find an authoritative source for all the existing mappings.
>> 2. Generate the radix tree files directly from the authoritative sources,
>> instead of the existing *.map files.
>> 3. Completely replace the existing binary-search code with this.
> It might be best to convert using the existing map files, and then
> update the mappings later. Otherwise, when things break, you won't
> know what to blame.
I think I went through this exercise last year or so, and updated the
notes about the authoritative sources where I was able to find one.
In the remaining cases, I believe that the maps have been intentionally
tweaked and we should be cautious about undoing that. Tatsuo-san might
remember more about why they are the way they are.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, hlinnaka@iki.fi, horiguchi.kyotaro@lab.ntt.co.jp, tsunakawa.takay@jp.fujitsu.com, ishii@sraoss.co.jp
Subject: Re: Radix tree for character conversion
In-Reply-To: <12566.1475857163@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox