pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: Christoph Berg <myon@debian.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pl/perl extension fails on Windows
Date: Thu, 10 Aug 2017 10:36:11 -0400
Message-ID: <12588.1502375771@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZ6dGEb7Yr9v8JdLX=KtAtdOTcD8PQUbDxVTGBazpQ-QQ@mail.gmail.com>
References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com>
	<4569.1499873707@sss.pgh.pa.us>
	<CA+OCxox=h5xftcnyk1AfA_QKSQSruD=Er0qweZakiCEg3U4rcg@mail.gmail.com>
	<20170713195345.2q6zmrtxumljhoui@msg.df7cb.de>
	<3254.1501276475@sss.pgh.pa.us>
	<20170730211444.uvedz2a24gusoaxr@msg.df7cb.de>
	<CAE9k0PnzYxyKHuwJonUEDt2xunPUc8VUVPWsd0BScRd3u+j8_A@mail.gmail.com>
	<20170731084044.q3wmppgt556zafzy@msg.df7cb.de>
	<30582.1501508356@sss.pgh.pa.us>
	<20170731164517.a34wxaapos7u5toj@msg.df7cb.de>
	<CANFyU96tucWPECj8Oy5cevuVwyijVoEZ_Dey08eCEhPk9TM85A@mail.gmail.com>
	<CA+TgmoZTu6wyjJ3vZNLuogCvXv9uwH0Xr+RMhJbo3L8f2eSVFg@mail.gmail.com>
	<CANFyU95XuHw8ajYHhg8BPdRSAa++n7MAHxpoEho90nPiEsTRKw@mail.gmail.com>
	<CA+Tgmob8We1gMW6mA-AKtc_Mx1LAGx9+aHOjmBEu_PYGDSpZkg@mail.gmail.com>
	<CAE9k0Pm9YcJqqkWXGvSQrkPGbH_f29VF7+=YzKNGOgnwnufa2Q@mail.gmail.com>
	<CA+TgmoZ6dGEb7Yr9v8JdLX=KtAtdOTcD8PQUbDxVTGBazpQ-QQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Aug 10, 2017 at 8:30 AM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>> So, the question is should we allow the preprocessor option
>> '_USE_32BIT_TIME_T' to be defined implicitly or not in postgresql
>> provided we are using Visual C compiler version > 8.0. I think this
>> should make plperl compatible with perl binaries.

> We've got this code in MSBuildProject.pm and VCBuildProject.pm:

>         # We have to use this flag on 32 bit targets because the 32bit perls
>         # are built with it and sometimes crash if we don't.
>         my $use_32bit_time_t =
>           $self->{platform} eq 'Win32' ? '_USE_32BIT_TIME_T;' : '';

> Based on the discussion upthread, I think we now know that this was
> not really the right approach.

Yeah ... however, if that's there, then there's something wrong with
Ashutosh's explanation, because that means we *are* building with
_USE_32BIT_TIME_T in 32-bit builds.  It's just getting there in a
roundabout way.  (Or, alternatively, this code is somehow not doing
anything at all.)

> The trouble with that is that _USE_32BIT_TIME_T also affects how
> PostgreSQL code compiles.

Really?  We try to avoid touching "time_t" at all in most of the code.
I bet that we could drop the above-cited code, and compile only plperl
with _USE_32BIT_TIME_T, taken (if present) from the Perl flags, and
it'd be fine.  At least, that's my first instinct for what to try.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (94+ messages)  latest in thread

Message-ID: <12588.1502375771@sss.pgh.pa.us>
Permalink:  ../12588.1502375771@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12588.1502375771@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, ashu.coek88@gmail.com, sandeep.thakkar@enterprisedb.com, myon@debian.org
  Subject: Re: pl/perl extension fails on Windows
  In-Reply-To: <12588.1502375771@sss.pgh.pa.us>
  References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com> <4569.1499873707@sss.pgh.pa.us> <CA+OCxox=h5xftcnyk1AfA_QKSQSruD=Er0qweZakiCEg3U4rcg@mail.gmail.com> <20170713195345.2q6zmrtxumljhoui@msg.df7cb.de> <3254.1501276475@sss.pgh.pa.us> <20170730211444.uvedz2a24gusoaxr@msg.df7cb.de> <CAE9k0PnzYxyKHuwJonUEDt2xunPUc8VUVPWsd0BScRd3u+j8_A@mail.gmail.com> <20170731084044.q3wmppgt556zafzy@msg.df7cb.de> <30582.1501508356@sss.pgh.pa.us> <20170731164517.a34wxaapos7u5toj@msg.df7cb.de> <CANFyU96tucWPECj8Oy5cevuVwyijVoEZ_Dey08eCEhPk9TM85A@mail.gmail.com> <CA+TgmoZTu6wyjJ3vZNLuogCvXv9uwH0Xr+RMhJbo3L8f2eSVFg@mail.gmail.com> <CANFyU95XuHw8ajYHhg8BPdRSAa++n7MAHxpoEho90nPiEsTRKw@mail.gmail.com> <CA+Tgmob8We1gMW6mA-AKtc_Mx1LAGx9+aHOjmBEu_PYGDSpZkg@mail.gmail.com> <CAE9k0Pm9YcJqqkWXGvSQrkPGbH_f29VF7+=YzKNGOgnwnufa2Q@mail.gmail.com> <CA+TgmoZ6dGEb7Yr9v8JdLX=KtAtdOTcD8PQUbDxVTGBazpQ-QQ@mail.gmail.com> <12588.1502375771@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox