pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Date: Fri, 17 Jun 2022 13:43:49 -0400
Message-ID: <1261896.1655487829@sss.pgh.pa.us> (raw)
In-Reply-To: <20220617173055.oaqns4ty235vlyyw@alap3.anarazel.de>
References: <20220616233130.rparivafipt6doj3@alap3.anarazel.de>
	<CAApHDvo3GOUK2YFJTjcECvB=0Jx==S-ywcVno9U1rZT_7r7+dg@mail.gmail.com>
	<CAH2-WznM2gGO7O0w1sWYdBV3U6RLZvRhoWEr20+dS02QV3hqjA@mail.gmail.com>
	<CAApHDvqivvMw=AgvVQA+dKEQJHxV5JVS8Nm48NZA+FT8vuuDcw@mail.gmail.com>
	<20220617052228.mjwns6ugspihamsc@alap3.anarazel.de>
	<20220617062456.ahbwho67m7c3lnr3@alap3.anarazel.de>
	<1221363.1655476388@sss.pgh.pa.us>
	<20220617173055.oaqns4ty235vlyyw@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> I should have been more precise - what I meant was a timeout.c API that allows
> the caller to pass in "now", which in this case we'd get from
> GetCurrentTransactionStopTimestamp(), which would avoid the additional
> timestamp computation.

I don't care for that one bit: it makes the accuracy of all timeouts
dependent on how careful that caller is to provide an up-to-date "now".
In the example at hand, there is WAY too much code between
SetCurrentTransactionStopTimestamp() and the timer arming to make me
think the results will be acceptable.

			regards, tom lane





view thread (75+ messages)  latest in thread

Message-ID: <1261896.1655487829@sss.pgh.pa.us>
Permalink:  ../1261896.1655487829@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1261896.1655487829@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, dgrowleyml@gmail.com, pg@bowt.ie, n.gluhov@postgrespro.ru, andrew@dunslane.net
  Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
  In-Reply-To: <1261896.1655487829@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox