pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: hlinnaka <hlinnaka@iki.fi>
Subject: Re: SerializeParamList vs machines with strict alignment
Date: Mon, 01 Oct 2018 23:52:30 -0400
Message-ID: <12777.1538452350@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1KFx+942LJSMt9-Z1p5yvmLqoXv78PaOsKYDgTnepTQ-g@mail.gmail.com>
References: <11629.1536550032@sss.pgh.pa.us>
	<CAA4eK1JfEc=cqiUiRvUcHYCf=PVEwM_bZ_QiOMHpqGpUMdY8gA@mail.gmail.com>
	<8352.1536586500@sss.pgh.pa.us>
	<CAA4eK1KTsNC--yPBatOiLJriBfGNgb_vmTF40JcEeZPedcL9YA@mail.gmail.com>
	<CAA4eK1KjGVrbMxaoE=tr1uR7mfpVLYui60tO4ANkQQAV+c+Y_A@mail.gmail.com>
	<27748.1538425312@sss.pgh.pa.us>
	<28627.1538426947@sss.pgh.pa.us>
	<CAEepm=1QkD_udoP3sxc_fci7x3PXQu3-Q-E-oempRuciSNp05Q@mail.gmail.com>
	<4694.1538438514@sss.pgh.pa.us>
	<CAA4eK1JYfe-Sxi3RjjBTnf1y1d-TNK+9nt1-cLajBuaXnJM+8A@mail.gmail.com>
	<8134.1538444333@sss.pgh.pa.us>
	<CAA4eK1KFx+942LJSMt9-Z1p5yvmLqoXv78PaOsKYDgTnepTQ-g@mail.gmail.com>

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Oct 2, 2018 at 7:08 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Also, I believe
>> that coding the test this way makes the leader send the param values to
>> multiple workers, which would flush out any problems with serializing a
>> value multiple times.  As against that, there's a hazard that the number
>> of workers might not be stable ...

> Yeah, I was actually more worried about instability part, but now I
> have tested it on both windows and centos machine and the test passes,
> so I am okay with that.  However, I feel if we want to go with that,
> there is actually no need of statement "SET force_parallel_mode=1".

OK, I hadn't tested to see if that could be dropped, but if it can,
then we don't need it.  The EXPLAIN is enough to ensure that the
test is doing what we want.  (I think we could drop the savepoint
too, no?)

			regards, tom lane




view thread (26+ messages)  latest in thread

Message-ID: <12777.1538452350@sss.pgh.pa.us>
Permalink:  ../12777.1538452350@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12777.1538452350@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, thomas.munro@enterprisedb.com, pgsql-hackers@lists.postgresql.org, hlinnaka@iki.fi
  Subject: Re: SerializeParamList vs machines with strict alignment
  In-Reply-To: <12777.1538452350@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox