From: Tom Lane <tgl@sss.pgh.pa.us>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: fix ancient typo in transformRelOptions()
Date: Tue, 05 Aug 2025 18:10:54 -0400
Message-ID: <1290107.1754431854@sss.pgh.pa.us> (raw)
In-Reply-To: <202508052156.d7n5jjro3jne@alvherre.pgsql>
References: <202508052156.d7n5jjro3jne@alvherre.pgsql>
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> On 2025-Aug-05, Nathan Bossart wrote:
>> I noticed that this function has a "namspace" parameter. The attached
>> patch adds the missing 'e'.
> I have vague recollections of it being this way because of "namespace"
> being a C++ keyword. (commit is 3a5b77371522, but I don't have energy
> to look for the discussion right now.)
Oh, duh -- if you try cpluspluscheck you'll find it's unhappy.
I didn't locate the discussion of "namspace" either, but I did
notice that de160e2c0 used "nameSpace" for the same purpose.
Maybe we should standardize on that? It looks less like a typo
than "namspace", for sure.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@kurilemu.de, nathandbossart@gmail.com
Subject: Re: fix ancient typo in transformRelOptions()
In-Reply-To: <1290107.1754431854@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox