agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Attempt to consolidate reading of XLOG page
Date: Mon, 15 Apr 2019 10:48:47 +0200
Message-ID: <12960.1555318127@localhost> (raw)
In-Reply-To: <20190412042746.GJ2144@paquier.xyz>
References: <14984.1554998742@spoje.net>
<20190412.122711.158276916.horiguchi.kyotaro@lab.ntt.co.jp>
<20190412042746.GJ2144@paquier.xyz>
Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Apr 12, 2019 at 12:27:11PM +0900, Kyotaro HORIGUCHI wrote:
> > This patch changes XLogRead to allow using other than
> > BasicOpenFile to open a segment, and use XLogReaderState.private
> > to hold a new struct XLogReadPos for the segment reader. The new
> > struct is heavily duplicated with XLogReaderState and I'm not
> > sure the rason why the XLogReadPos is needed.
> > Any other opinions, or thoughts?
>
> The focus is on the stability of v12 for the next couple of months, so
> please make sure to register it to the next CF if you want feedback.
ok, will do. (A link to mailing list is needed for the CF entry, so I had to
post something anyway :-) Since I don't introduce any kind of "cool new
feature" here, I believe it did not disturb much.)
> Here are some basic thoughts after a very quick lookup.
> ...
Thanks.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (62+ messages) latest in thread
Message-ID: <12960.1555318127@localhost>
Permalink: ../12960.1555318127@localhost/
Also on: postgresql.org/message-id/12960.1555318127@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, michael@paquier.xyz
Subject: Re: Attempt to consolidate reading of XLOG page
In-Reply-To: <12960.1555318127@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox